about summary refs log tree commit diff
diff options
context:
space:
mode:
authorSamuel Thibault <samuel.thibault@ens-lyon.org>2020-06-26 22:44:30 +0200
committerSamuel Thibault <samuel.thibault@ens-lyon.org>2020-06-26 23:51:52 +0200
commitb9ca3f3efb4659cadf4b0b81308ce9d45de61e0b (patch)
treeadfc5d80a84fada612b6004c70e56c7dbb36b8dd
parent4fdd4d41a17dda26c854ed935658154a17d4b906 (diff)
downloadglibc-b9ca3f3efb4659cadf4b0b81308ce9d45de61e0b.tar.gz
glibc-b9ca3f3efb4659cadf4b0b81308ce9d45de61e0b.tar.xz
glibc-b9ca3f3efb4659cadf4b0b81308ce9d45de61e0b.zip
tst-cancel4-common.c: fix calling socketpair
PF_UNIX was actually never intended to be passed as protocol parameter to
socket() calls: it is a protocol family, not a protocol.  It happens that
Linux introduced accepting it during its 2.0 development, but it shouldn't.
OpenBSD kernels accept it as well, but FreeBSD and NetBSD rightfully do not.
GNU/Hurd does not either.

* nptl/tst-cancel4-common.c (do_test): Pass 0 instead of PF_UNIX as
protocol.
-rw-r--r--nptl/tst-cancel4-common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/nptl/tst-cancel4-common.c b/nptl/tst-cancel4-common.c
index f2026b81f4..9a6924c1c6 100644
--- a/nptl/tst-cancel4-common.c
+++ b/nptl/tst-cancel4-common.c
@@ -20,7 +20,7 @@
 static int
 do_test (void)
 {
-  if (socketpair (AF_UNIX, SOCK_STREAM, PF_UNIX, fds) != 0)
+  if (socketpair (AF_UNIX, SOCK_STREAM, 0, fds) != 0)
     {
       perror ("socketpair");
       exit (1);