diff options
| author | Florian Weimer <fweimer@redhat.com> | 2019-11-28 14:42:11 +0100 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2019-11-28 14:42:11 +0100 |
| commit | f55e312bcd6582b5ff68fdcc1781c7017796dc91 (patch) | |
| tree | c3226381ee531d41bb27083acdec830705a474ff | |
| parent | 7966ce07e89fa4ccc8fdba00d4439fc652862462 (diff) | |
| download | glibc-f55e312bcd6582b5ff68fdcc1781c7017796dc91.tar.gz glibc-f55e312bcd6582b5ff68fdcc1781c7017796dc91.tar.xz glibc-f55e312bcd6582b5ff68fdcc1781c7017796dc91.zip | |
libio: Disable vtable validation for pre-2.1 interposed handles [BZ #25203]
Commit c402355dfa7807b8e0adb27c009135a7e2b9f1b0 ("libio: Disable
vtable validation in case of interposition [BZ #23313]") only covered
the interposable glibc 2.1 handles, in libio/stdfiles.c. The
parallel code in libio/oldstdfiles.c needs similar detection logic.
Fixes (again) commit db3476aff19b75c4fdefbe65fcd5f0a90588ba51
("libio: Implement vtable verification [BZ #20191]").
Change-Id: Ief6f9f17e91d1f7263421c56a7dc018f4f595c21
(cherry picked from commit cb61630ed712d033f54295f776967532d3f4b46a)
| -rw-r--r-- | NEWS | 1 | ||||
| -rw-r--r-- | libio/oldstdfiles.c | 5 |
2 files changed, 6 insertions, 0 deletions
diff --git a/NEWS b/NEWS index 2a97ce5dac..74efb0e6e8 100644 --- a/NEWS +++ b/NEWS @@ -69,6 +69,7 @@ The following bugs are resolved with this release: [24228] old x86 applications that use legacy libio crash on exit [24476] dlfcn: Guard __dlerror_main_freeres with __libc_once_get (once) [24744] io: Remove the copy_file_range emulation. + [25203] libio: Disable vtable validation for pre-2.1 interposed handles [25204] Ignore LD_PREFER_MAP_32BIT_EXEC for SUID programs Security related changes: diff --git a/libio/oldstdfiles.c b/libio/oldstdfiles.c index f3dda89004..9fe809bd68 100644 --- a/libio/oldstdfiles.c +++ b/libio/oldstdfiles.c @@ -87,6 +87,11 @@ _IO_check_libio (void) stdout->_vtable_offset = stderr->_vtable_offset = ((int) sizeof (struct _IO_FILE) - (int) sizeof (struct _IO_FILE_complete)); + + if (_IO_stdin_.vtable != &_IO_old_file_jumps + || _IO_stdout_.vtable != &_IO_old_file_jumps + || _IO_stderr_.vtable != &_IO_old_file_jumps) + IO_set_accept_foreign_vtables (&_IO_vtable_check); } } |