diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2020-07-09 13:24:04 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2020-07-13 09:16:11 -0300 |
| commit | 10b01bd4529336bffc2c398ce43a171ed94aacc7 (patch) | |
| tree | 62ba252dd57aec8ac577d211783010ab89850ca1 | |
| parent | e72b98e6f858583a3ef904e27c6fbd932bdc86c8 (diff) | |
| download | glibc-10b01bd4529336bffc2c398ce43a171ed94aacc7.tar.gz glibc-10b01bd4529336bffc2c398ce43a171ed94aacc7.tar.xz glibc-10b01bd4529336bffc2c398ce43a171ed94aacc7.zip | |
string: Make tst-strerror/tst-strsignal unsupported if msgfmt is not installed
Without msgfmt libc.mo files are not generated and its loading failure is silent ignored with xsetlocale. Also unset LANGUAGE environment variable to avoid it taking precedence when loading the message catalog. Although not strictly required (since the test is issued with test-container and it sets a strict environment variable) it follows other tests that deal with translation. Checked on x86_64-linux-gnu.
| -rw-r--r-- | string/Makefile | 9 | ||||
| -rw-r--r-- | string/tst-strerror.c | 3 | ||||
| -rw-r--r-- | string/tst-strsignal.c | 3 |
3 files changed, 14 insertions, 1 deletions
diff --git a/string/Makefile b/string/Makefile index 206c9b103c..c5b8909f37 100644 --- a/string/Makefile +++ b/string/Makefile @@ -65,7 +65,14 @@ tests := tester inl-tester noinl-tester testcopy test-ffs \ test-endian-sign-conversion tst-memmove-overflow \ test-sig_np -tests-container += tst-strsignal tst-strerror +# Both tests require the .mo translation files generated by msgfmt. +tests-translation := tst-strsignal \ + tst-strerror + +tests-container += $(tests-translation) +ifeq ($(MSGFMT),:) +tests-unsupported += $(tests-translation) +endif # This test allocates a lot of memory and can run for a long time. xtests = tst-strcoll-overflow diff --git a/string/tst-strerror.c b/string/tst-strerror.c index 3af51236d7..1fc202e4ea 100644 --- a/string/tst-strerror.c +++ b/string/tst-strerror.c @@ -19,6 +19,7 @@ #include <string.h> #include <stdio.h> +#include <stdlib.h> #include <errno.h> #include <locale.h> #include <array_length.h> @@ -29,6 +30,8 @@ static int do_test (void) { + unsetenv ("LANGUAGE"); + xsetlocale (LC_ALL, "C"); TEST_COMPARE_STRING (strerror (EINVAL), "Invalid argument"); diff --git a/string/tst-strsignal.c b/string/tst-strsignal.c index 3f6764989f..2c549f4620 100644 --- a/string/tst-strsignal.c +++ b/string/tst-strsignal.c @@ -20,6 +20,7 @@ #include <string.h> #include <stdio.h> #include <signal.h> +#include <stdlib.h> #include <locale.h> #include <array_length.h> @@ -29,6 +30,8 @@ static int do_test (void) { + unsetenv ("LANGUAGE"); + xsetlocale (LC_ALL, "C"); TEST_COMPARE_STRING (strsignal (SIGINT), "Interrupt"); |