diff options
| author | Siddhesh Poyarekar <siddhesh@redhat.com> | 2014-02-27 21:29:16 +0530 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@redhat.com> | 2014-02-27 21:29:16 +0530 |
| commit | ffe768a90912f9bce43b70a82576b3dc99e3121c (patch) | |
| tree | e5b2d4c110c959fdd21974d2afde892823eec049 | |
| parent | ac0b347743833452b8ff56cb94eab5da95136b70 (diff) | |
| download | glibc-ffe768a90912f9bce43b70a82576b3dc99e3121c.tar.gz glibc-ffe768a90912f9bce43b70a82576b3dc99e3121c.tar.xz glibc-ffe768a90912f9bce43b70a82576b3dc99e3121c.zip | |
Fix sign of input to bsloww1 (BZ #16623)
In 84ba214c, I removed some redundant sign computations and in the process, I incorrectly got rid of a temporary variable, thus passing the absolute value of the input to bsloww1. This caused #16623. This fix undoes the incorrect change.
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | NEWS | 2 | ||||
| -rw-r--r-- | sysdeps/ieee754/dbl-64/s_sin.c | 16 |
3 files changed, 18 insertions, 7 deletions
diff --git a/ChangeLog b/ChangeLog index b65e16f820..8c6db1b4a1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2014-02-27 Siddhesh Poyarekar <siddhesh@redhat.com> + + [BZ #16623] + * sysdeps/ieee754/dbl-64/s_sin.c (__sin): Preserve sign of A + and DA. + (__cos): Likewise. + 2014-02-12 Dylan Alex Simon <dylan@dylex.net> [BZ #16545] diff --git a/NEWS b/NEWS index 7b52f1f2b6..6a3c57ef1d 100644 --- a/NEWS +++ b/NEWS @@ -9,7 +9,7 @@ Version 2.19.1 * The following bugs are resolved with this release: - 16545. + 16545, 16623. Version 2.19 diff --git a/sysdeps/ieee754/dbl-64/s_sin.c b/sysdeps/ieee754/dbl-64/s_sin.c index 6105e9fbdf..50109b8dd4 100644 --- a/sysdeps/ieee754/dbl-64/s_sin.c +++ b/sysdeps/ieee754/dbl-64/s_sin.c @@ -447,19 +447,21 @@ __sin (double x) } else { + double t; if (a > 0) { m = 1; + t = a; db = da; } else { m = 0; - a = -a; + t = -a; db = -da; } - u.x = big + a; - y = a - (u.x - big); + u.x = big + t; + y = t - (u.x - big); res = do_sin (u, y, db, &cor); cor = (cor > 0) ? 1.035 * cor + eps : 1.035 * cor - eps; retval = ((res == res + cor) ? ((m) ? res : -res) @@ -671,19 +673,21 @@ __cos (double x) } else { + double t; if (a > 0) { m = 1; + t = a; db = da; } else { m = 0; - a = -a; + t = -a; db = -da; } - u.x = big + a; - y = a - (u.x - big); + u.x = big + t; + y = t - (u.x - big); res = do_sin (u, y, db, &cor); cor = (cor > 0) ? 1.035 * cor + eps : 1.035 * cor - eps; retval = ((res == res + cor) ? ((m) ? res : -res) |