diff options
| author | Chris Metcalf <cmetcalf@ezchip.com> | 2015-08-04 12:02:10 -0400 |
|---|---|---|
| committer | Chris Metcalf <cmetcalf@ezchip.com> | 2015-08-04 12:07:53 -0400 |
| commit | 0d261f406d7c8f70b4ad7ca7d9247da1db3dfb41 (patch) | |
| tree | 690d97fa7ac0fb9a31b97085ae77c7063507db97 | |
| parent | bbab82c25da9b504c0804119840de7aeab0eeeba (diff) | |
| download | glibc-0d261f406d7c8f70b4ad7ca7d9247da1db3dfb41.tar.gz glibc-0d261f406d7c8f70b4ad7ca7d9247da1db3dfb41.tar.xz glibc-0d261f406d7c8f70b4ad7ca7d9247da1db3dfb41.zip | |
tilepro: fix warnings in sysdeps/tile/tilepro/bits/atomic.h
Using a ({ }) structure avoids the "value computed is not used"
that a simple () structure causes.
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | sysdeps/tile/tilepro/bits/atomic.h | 20 |
2 files changed, 18 insertions, 8 deletions
diff --git a/ChangeLog b/ChangeLog index 3cf69712ad..17caaf3e91 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2015-08-04 Chris Metcalf <cmetcalf@ezchip.com> + + * sysdeps/tile/tilepro/bits/atomic.h (__atomic_update): + Restructure macro to avoid "value computed is not used" warning. + (atomic_compare_and_exchange_val_acq): Likewise. + 2015-08-04 Andreas Schwab <schwab@suse.de> [BZ #18635] diff --git a/sysdeps/tile/tilepro/bits/atomic.h b/sysdeps/tile/tilepro/bits/atomic.h index 491e586cee..e0ef9fb5e7 100644 --- a/sysdeps/tile/tilepro/bits/atomic.h +++ b/sysdeps/tile/tilepro/bits/atomic.h @@ -39,10 +39,12 @@ int __atomic_cmpxchg_32 (volatile int *mem, int newval, int oldval) } #define atomic_compare_and_exchange_val_acq(mem, n, o) \ - ((__typeof (*(mem))) \ - ((sizeof (*(mem)) == 4) ? \ - __atomic_cmpxchg_32 ((int *) (mem), (int) (n), (int) (o)) : \ - __atomic_error_bad_argument_size())) + ({ \ + if (sizeof (*(mem)) != 4) \ + __atomic_error_bad_argument_size (); \ + (__typeof (*(mem))) \ + __atomic_cmpxchg_32 ((int *) (mem), (int) (n), (int) (o)); \ + }) /* Atomically compute: int old = *ptr; @@ -64,10 +66,12 @@ int __atomic_update_32 (volatile int *mem, int mask, int addend) /* Size-checked verson of __atomic_update_32. */ #define __atomic_update(mem, mask, addend) \ - ((__typeof (*(mem))) \ - ((sizeof (*(mem)) == 4) ? \ - __atomic_update_32 ((int *) (mem), (int) (mask), (int) (addend)) : \ - __atomic_error_bad_argument_size ())) + ({ \ + if (sizeof (*(mem)) != 4) \ + __atomic_error_bad_argument_size (); \ + (__typeof (*(mem))) \ + __atomic_update_32 ((int *) (mem), (int) (mask), (int) (addend)); \ + }) #define atomic_exchange_acq(mem, newvalue) \ __atomic_update ((mem), 0, (newvalue)) |