diff options
| author | Florian Weimer <fweimer@redhat.com> | 2017-12-14 15:05:57 +0100 |
|---|---|---|
| committer | Aurelien Jarno <aurelien@aurel32.net> | 2017-12-16 14:47:11 +0100 |
| commit | a8920e694ab23f25435329b2365efa5ca7ac64bd (patch) | |
| tree | e694a3b723d784d1aecebc33bf895c0f485243f8 | |
| parent | 778a7c1825abe6273562617836c49b9573c394e8 (diff) | |
| download | glibc-a8920e694ab23f25435329b2365efa5ca7ac64bd.tar.gz glibc-a8920e694ab23f25435329b2365efa5ca7ac64bd.tar.xz glibc-a8920e694ab23f25435329b2365efa5ca7ac64bd.zip | |
elf: Count components of the expanded path in _dl_init_path [BZ #22607]
(cherry picked from commit 3ff3dfa5af313a6ea33f3393916f30eece4f0171)
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | NEWS | 6 | ||||
| -rw-r--r-- | elf/dl-load.c | 13 |
3 files changed, 17 insertions, 9 deletions
diff --git a/ChangeLog b/ChangeLog index c16512bbc0..1868c7a7be 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2017-12-14 Florian Weimer <fweimer@redhat.com> + [BZ #22607] + CVE-2017-1000409 + * elf/dl-load.c (_dl_init_paths): Compute number of components in + the expanded path string. + +2017-12-14 Florian Weimer <fweimer@redhat.com> + [BZ #22606] CVE-2017-1000408 * elf/dl-load.c (system_dirs): Update comment. diff --git a/NEWS b/NEWS index c0596ae5f2..2c4c9d63aa 100644 --- a/NEWS +++ b/NEWS @@ -30,6 +30,12 @@ Security related changes: it is mentioned here only because of the CVE assignment.) Reported by Qualys. + CVE-2017-1000409: Buffer overflow in _dl_init_paths due to miscomputation + of the number of search path components. (This is not a security + vulnerability per se because no trust boundary is crossed if the fix for + CVE-2017-1000366 has been applied, but it is mentioned here only because + of the CVE assignment.) Reported by Qualys. + The following bugs are resolved with this release: [20257] sunrpc: clntudp_call does not enforce timeout when receiving data diff --git a/elf/dl-load.c b/elf/dl-load.c index c8cf96e226..92303b08e6 100644 --- a/elf/dl-load.c +++ b/elf/dl-load.c @@ -776,8 +776,6 @@ _dl_init_paths (const char *llp) if (llp != NULL && *llp != '\0') { - size_t nllp; - const char *cp = llp; char *llp_tmp; #ifdef SHARED @@ -800,13 +798,10 @@ _dl_init_paths (const char *llp) /* Decompose the LD_LIBRARY_PATH contents. First determine how many elements it has. */ - nllp = 1; - while (*cp) - { - if (*cp == ':' || *cp == ';') - ++nllp; - ++cp; - } + size_t nllp = 1; + for (const char *cp = llp_tmp; *cp != '\0'; ++cp) + if (*cp == ':' || *cp == ';') + ++nllp; env_path_list.dirs = (struct r_search_path_elem **) malloc ((nllp + 1) * sizeof (struct r_search_path_elem *)); |