about summary refs log tree commit diff
diff options
context:
space:
mode:
authorSiddhesh Poyarekar <siddhesh@sourceware.org>2016-12-30 09:42:38 +0530
committerSiddhesh Poyarekar <siddhesh@sourceware.org>2016-12-30 09:42:38 +0530
commit31cd0548168e87ecfba01cc33e9609ac2b95b70f (patch)
treee4422537c74ccc8e30f808233550987b5aa3237d
parenta9b0101475c9894f210e20efa9738eba56d33f19 (diff)
downloadglibc-31cd0548168e87ecfba01cc33e9609ac2b95b70f.tar.gz
glibc-31cd0548168e87ecfba01cc33e9609ac2b95b70f.tar.xz
glibc-31cd0548168e87ecfba01cc33e9609ac2b95b70f.zip
Fix pretty printer tests for run-built-tests == no
In my change to add configure tests for python I had a brainfart where
I tried to filter out unsupported tests from tests-printers-programs
instead of tests-printers to select tests to build.  I realize now
that all of that is completely unnecessary and it would be safe to
just build the tests as long as we don't try to run it.

This patch reverts that bit of the change.  Tested with
run-built-tests = no in config.make.

	* Rules (tests): Add tests-printers-programs to tests to be
	built.
-rw-r--r--ChangeLog5
-rw-r--r--Rules6
2 files changed, 8 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 60b905d569..f188d884ba 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-12-30  Siddhesh Poyarekar  <siddhesh@sourceware.org>
+
+	* Rules (tests): Add tests-printers-programs to tests to be
+	built.
+
 2016-12-28  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
 	* sysvipc/Makefile (tests): Add test-sysvshm.
diff --git a/Rules b/Rules
index 558924d653..3195f590d3 100644
--- a/Rules
+++ b/Rules
@@ -129,9 +129,9 @@ endif
 others: $(py-const)
 
 ifeq ($(run-built-tests),no)
-tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests) \
-			       $(tests-printers-programs)) \
-			     $(test-srcs)) $(tests-special)
+tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests)) \
+			     $(test-srcs)) $(tests-special) \
+			     $(tests-printers-programs)
 xtests: tests $(xtests-special)
 else
 tests: $(tests:%=$(objpfx)%.out) $(tests-special) $(tests-printers-out)