diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2016-06-07 22:54:58 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2016-06-07 22:54:58 +0000 |
| commit | c23805a95d9bc095118299b5965f7f8388e57fc4 (patch) | |
| tree | 07c18e319ccd3723c1dab867e1289d31e84a6b12 | |
| parent | 91655fc307fec2d5a8d60446b4de11cc986b47fa (diff) | |
| download | glibc-c23805a95d9bc095118299b5965f7f8388e57fc4.tar.gz glibc-c23805a95d9bc095118299b5965f7f8388e57fc4.tar.xz glibc-c23805a95d9bc095118299b5965f7f8388e57fc4.zip | |
Fix i386 asinhl (sNaN) (bug 20218).
The i386 version of asinhl returns sNaN (without raising any exceptions) for sNaN input. This patch fixes it to add non-finite arguments to themselves, so that "invalid" is raised and qNaN returned. Tested for x86_64 and x86. [BZ #20218] * sysdeps/i386/fpu/s_asinhl.S (__asinhl): Add non-finite argument to itself. * math/libm-test.inc (asinh_test_data): Add sNaN tests.
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | math/libm-test.inc | 2 | ||||
| -rw-r--r-- | sysdeps/i386/fpu/s_asinhl.S | 1 |
3 files changed, 10 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 5688d2009f..cba504e7b2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2016-06-07 Joseph Myers <joseph@codesourcery.com> + + [BZ #20218] + * sysdeps/i386/fpu/s_asinhl.S (__asinhl): Add non-finite argument + to itself. + * math/libm-test.inc (asinh_test_data): Add sNaN tests. + 2016-06-07 H.J. Lu <hongjiu.lu@intel.com> [BZ #20195] diff --git a/math/libm-test.inc b/math/libm-test.inc index f9b2c8ada8..fb7a71baf8 100644 --- a/math/libm-test.inc +++ b/math/libm-test.inc @@ -1878,6 +1878,8 @@ static const struct test_f_f_data asinh_test_data[] = TEST_f_f (asinh, minus_infty, minus_infty, ERRNO_UNCHANGED|NO_TEST_INLINE), TEST_f_f (asinh, qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), TEST_f_f (asinh, -qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_f (asinh, snan_value, qnan_value, INVALID_EXCEPTION), + TEST_f_f (asinh, -snan_value, qnan_value, INVALID_EXCEPTION), AUTO_TESTS_f_f (asinh), }; diff --git a/sysdeps/i386/fpu/s_asinhl.S b/sysdeps/i386/fpu/s_asinhl.S index c9d5714bee..e055386071 100644 --- a/sysdeps/i386/fpu/s_asinhl.S +++ b/sysdeps/i386/fpu/s_asinhl.S @@ -88,6 +88,7 @@ ENTRY(__asinhl) 4: ret 7: fldt 4(%esp) + fadd %st ret 6: faddl MO(one) |