about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2016-06-06 22:21:11 +0000
committerJoseph Myers <joseph@codesourcery.com>2016-06-06 22:21:11 +0000
commit3d8b06bc6108aa20a6591f52e7d9cbbd63c20e0a (patch)
tree4d39272f31ecc39b6e42fa8179a4b1c8591502c2
parentaf5fdf5a358329161cc3960f5e54fac16dbb8063 (diff)
downloadglibc-3d8b06bc6108aa20a6591f52e7d9cbbd63c20e0a.tar.gz
glibc-3d8b06bc6108aa20a6591f52e7d9cbbd63c20e0a.tar.xz
glibc-3d8b06bc6108aa20a6591f52e7d9cbbd63c20e0a.zip
Fix dbl-64 asin (sNaN) (bug 20213).
The dbl-64 version of asin returns sNaN for sNaN arguments.  This
patch fixes it to add NaN arguments to themselves so that qNaN is
returned in this case.

Tested for x86_64 and x86.

	[BZ #20213]
	* sysdeps/ieee754/dbl-64/e_asin.c (__ieee754_asin): Add NaN
	argument to itself.
	* math/libm-test.inc (asin_test_data): Add sNaN tests.
-rw-r--r--ChangeLog7
-rw-r--r--math/libm-test.inc2
-rw-r--r--sysdeps/ieee754/dbl-64/e_asin.c2
3 files changed, 10 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index e207a71005..b839cfb11c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2016-06-06  Joseph Myers  <joseph@codesourcery.com>
+
+	[BZ #20213]
+	* sysdeps/ieee754/dbl-64/e_asin.c (__ieee754_asin): Add NaN
+	argument to itself.
+	* math/libm-test.inc (asin_test_data): Add sNaN tests.
+
 2016-06-06  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
 	* misc/Makefile (CFLAGS-pwritev.c): New variable: add cancellation
diff --git a/math/libm-test.inc b/math/libm-test.inc
index 698172080c..f9b2c8ada8 100644
--- a/math/libm-test.inc
+++ b/math/libm-test.inc
@@ -1853,6 +1853,8 @@ static const struct test_f_f_data asin_test_data[] =
     TEST_f_f (asin, minus_infty, qnan_value, INVALID_EXCEPTION|ERRNO_EDOM),
     TEST_f_f (asin, qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
     TEST_f_f (asin, -qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
+    TEST_f_f (asin, snan_value, qnan_value, INVALID_EXCEPTION),
+    TEST_f_f (asin, -snan_value, qnan_value, INVALID_EXCEPTION),
 
     /* asin x == qNaN plus invalid exception for |x| > 1.  */
     TEST_f_f (asin, 1.125L, qnan_value, INVALID_EXCEPTION|ERRNO_EDOM),
diff --git a/sysdeps/ieee754/dbl-64/e_asin.c b/sysdeps/ieee754/dbl-64/e_asin.c
index 5d5fb01132..23e9e7eddd 100644
--- a/sysdeps/ieee754/dbl-64/e_asin.c
+++ b/sysdeps/ieee754/dbl-64/e_asin.c
@@ -323,7 +323,7 @@ __ieee754_asin(double x){
   /*---------------------------- |x|>=1 -------------------------------*/
   else if (k==0x3ff00000 && u.i[LOW_HALF]==0) return (m>0)?hp0.x:-hp0.x;
   else
-  if (k>0x7ff00000 || (k == 0x7ff00000 && u.i[LOW_HALF] != 0)) return x;
+  if (k>0x7ff00000 || (k == 0x7ff00000 && u.i[LOW_HALF] != 0)) return x + x;
   else {
     u.i[HIGH_HALF]=0x7ff00000;
     v.i[HIGH_HALF]=0x7ff00000;