about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.com>2016-03-21 12:10:20 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.com>2016-03-21 12:12:26 -0300
commit67b23376fb72cdc3fbef37837f6fb5ebe8f0f034 (patch)
tree2a50742b54852b2c48fd3666aec36e845814900f
parent893e371b2f27f7fd6f503cefce8d9f754aaefd58 (diff)
downloadglibc-67b23376fb72cdc3fbef37837f6fb5ebe8f0f034.tar.gz
glibc-67b23376fb72cdc3fbef37837f6fb5ebe8f0f034.tar.xz
glibc-67b23376fb72cdc3fbef37837f6fb5ebe8f0f034.zip
posix: Fix posix_spawn implict check style
This patch fixes the implicit check style add in 2a69f853c for the
general convention one.

Checked on x86_64.

	* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Fix implict checks
	style.
-rw-r--r--ChangeLog5
-rw-r--r--sysdeps/unix/sysv/linux/spawni.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index f662d9aef7..ffaf973d14 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-21  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
+
+	* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Fix implict checks
+	style.
+
 2016-03-21  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* sysdeps/unix/sysv/linux/x86_64/cancellation.S
diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c
index cb80cea00f..ee05de5a9b 100644
--- a/sysdeps/unix/sysv/linux/spawni.c
+++ b/sysdeps/unix/sysv/linux/spawni.c
@@ -381,7 +381,7 @@ __spawnix (pid_t * pid, const char *file,
 
   close_not_cancel (args.pipe[0]);
 
-  if (!ec && pid)
+  if ((ec == 0) && (pid != NULL))
     *pid = new_pid;
 
   __sigprocmask (SIG_SETMASK, &args.oldmask, 0);