about summary refs log tree commit diff
diff options
context:
space:
mode:
authorKamlesh Kumar <kamleshbhalui@gmail.com>2019-12-05 16:49:00 +0100
committerFangrui Song <maskray@google.com>2022-05-24 21:21:05 -0700
commit2fa202fdd10de62ca436d567f12ccc3e40f29476 (patch)
tree0c0ab41d9d37cb1237c049da748de31313dfefbb
parent20f6c924222f2677d9a53fa3b6c1ea76a1341840 (diff)
downloadglibc-2fa202fdd10de62ca436d567f12ccc3e40f29476.tar.gz
glibc-2fa202fdd10de62ca436d567f12ccc3e40f29476.tar.xz
glibc-2fa202fdd10de62ca436d567f12ccc3e40f29476.zip
<string.h>: Define __CORRECT_ISO_CPP_STRING_H_PROTO for Clang [BZ #25232]
Without the asm redirects, strchr et al. are not const-correct.

libc++ has a wrapper header that works with and without
__CORRECT_ISO_CPP_STRING_H_PROTO (using a Clang extension).  But when
Clang is used with libstdc++ or just C headers, the overloaded functions
with the correct types are not declared.

This change does not impact current GCC (with libstdc++ or libc++).

(cherry picked from commit 953ceff17a4a15b10cfdd5edc3c8cae4884c8ec3)
-rw-r--r--string/string.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/string/string.h b/string/string.h
index 150cfd8b13..22cd0fa08f 100644
--- a/string/string.h
+++ b/string/string.h
@@ -33,7 +33,8 @@ __BEGIN_DECLS
 #include <stddef.h>
 
 /* Tell the caller that we provide correct C++ prototypes.  */
-#if defined __cplusplus && __GNUC_PREREQ (4, 4)
+#if defined __cplusplus && (__GNUC_PREREQ (4, 4) \
+			    || __glibc_clang_prereq (3, 5))
 # define __CORRECT_ISO_CPP_STRING_H_PROTO
 #endif