diff options
| author | Andreas Schwab <schwab@linux-m68k.org> | 2021-06-25 15:02:47 +0200 |
|---|---|---|
| committer | Fangrui Song <i@maskray.me> | 2021-08-27 17:26:08 -0700 |
| commit | 6056776143dbc9cb0b62fc3c0f1ce5f44bbb3a71 (patch) | |
| tree | 3313c3ca32af053b3f3bf290c0447e4c7f4b3fe4 | |
| parent | 359a244dc60094ced02138ab9840a908d5f9410a (diff) | |
| download | glibc-6056776143dbc9cb0b62fc3c0f1ce5f44bbb3a71.tar.gz glibc-6056776143dbc9cb0b62fc3c0f1ce5f44bbb3a71.tar.xz glibc-6056776143dbc9cb0b62fc3c0f1ce5f44bbb3a71.zip | |
wordexp: handle overflow in positional parameter number (bug 28011)
Use strtoul instead of atoi so that overflow can be detected.
| -rw-r--r-- | posix/wordexp-test.c | 1 | ||||
| -rw-r--r-- | posix/wordexp.c | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/posix/wordexp-test.c b/posix/wordexp-test.c index cc29840355..30c1dd65ef 100644 --- a/posix/wordexp-test.c +++ b/posix/wordexp-test.c @@ -200,6 +200,7 @@ struct test_case_struct { 0, NULL, "$var", 0, 0, { NULL, }, IFS }, { 0, NULL, "\"\\n\"", 0, 1, { "\\n", }, IFS }, { 0, NULL, "", 0, 0, { NULL, }, IFS }, + { 0, NULL, "${1234567890123456789012}", 0, 0, { NULL, }, IFS }, /* Flags not already covered (testit() has special handling for these) */ { 0, NULL, "one two", WRDE_DOOFFS, 2, { "one", "two", }, IFS }, diff --git a/posix/wordexp.c b/posix/wordexp.c index 8e33ad95b0..b13b0d4b20 100644 --- a/posix/wordexp.c +++ b/posix/wordexp.c @@ -1407,7 +1407,7 @@ envsubst: /* Is it a numeric parameter? */ else if (isdigit (env[0])) { - int n = atoi (env); + unsigned long n = strtoul (env, NULL, 10); if (n >= __libc_argc) /* Substitute NULL. */ |