summary refs log tree commit diff
diff options
context:
space:
mode:
authorLeonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>2018-12-10 14:52:23 -0600
committerLeonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>2018-12-12 11:05:22 -0600
commit587426d499e6ac40dafd9a19dcd12cb6af93f5fc (patch)
treebff685386a3108bd73bfa7b5b180bb29b5c31e93
parent46703efa02f6ddebce5ee54c92f7c32598de0de6 (diff)
downloadglibc-587426d499e6ac40dafd9a19dcd12cb6af93f5fc.tar.gz
glibc-587426d499e6ac40dafd9a19dcd12cb6af93f5fc.tar.xz
glibc-587426d499e6ac40dafd9a19dcd12cb6af93f5fc.zip
benchtests: keep comparing even if function timings do not match
Allows other functions to be processed, making the script a bit more fault
tolerant thus useful.

	* benchtests/scripts/compare_bench.py (compare_runs): Continue instead of return.
-rw-r--r--ChangeLog5
-rwxr-xr-xbenchtests/scripts/compare_bench.py2
2 files changed, 6 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index f85b3f5fd9..18b9f37637 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-12  Leonardo Sandoval  <leonardo.sandoval.gonzalez@intel.com>
+
+	* benchtests/scripts/compare_bench.py (compare_runs): Continue
+	instead of return.
+
 2018-12-12  Florian Weimer  <fweimer@redhat.com>
 
 	* sysdeps/posix/timespec_get.c: Add missing “any later version”
diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py
index f4b7742f90..9cbbda6be6 100755
--- a/benchtests/scripts/compare_bench.py
+++ b/benchtests/scripts/compare_bench.py
@@ -77,7 +77,7 @@ def compare_runs(pts1, pts2, threshold):
             # timing info for the function variant.
             if 'timings' not in pts1['functions'][func][var].keys() or \
                 'timings' not in pts2['functions'][func][var].keys():
-                    return
+                    continue
 
             # If two lists do not have the same length then it is likely that
             # the performance characteristics of the function have changed.