summary refs log tree commit diff
diff options
context:
space:
mode:
authorUlrich Drepper <drepper@redhat.com>2002-10-12 06:34:56 +0000
committerUlrich Drepper <drepper@redhat.com>2002-10-12 06:34:56 +0000
commitcc12f2a442d1d971d6ec0c21bdfa578299601fc7 (patch)
tree2d4f96a7c563e25200a940fade4aea05e4203a7b
parentf44476711db142376aa30182b23384037905b910 (diff)
downloadglibc-cc12f2a442d1d971d6ec0c21bdfa578299601fc7.tar.gz
glibc-cc12f2a442d1d971d6ec0c21bdfa578299601fc7.tar.xz
glibc-cc12f2a442d1d971d6ec0c21bdfa578299601fc7.zip
Update.
	* elf/dl-load.c (_dl_map_object_from_fd): Remove unnecessarily
	duplicated variable c.

	* sysdeps/unix/sysv/linux/sigwait.c (__sigwait): Use INTERNAL_SYSCALL
	if possible.
	Add hack to prevent the compiler from clobbering the signal context.
-rw-r--r--ChangeLog10
-rw-r--r--elf/dl-load.c38
-rw-r--r--sysdeps/unix/sysv/linux/i386/sysdep.h2
3 files changed, 25 insertions, 25 deletions
diff --git a/ChangeLog b/ChangeLog
index 6ba5af12ed..1842411d1d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,15 +1,17 @@
 2002-10-11  Ulrich Drepper  <drepper@redhat.com>
 
-	* sysdeps/unix/sysv/linux/sigwait.c (__sigwait): Use
-	INTERNAL_SYSCALL is possible.
+	* elf/dl-load.c (_dl_map_object_from_fd): Remove unnecessarily
+	duplicated variable c.
+
+	* sysdeps/unix/sysv/linux/sigwait.c (__sigwait): Use INTERNAL_SYSCALL
+	if possible.
 
 	* sysdeps/unix/sysv/linux/i386/sysdep.h
 	(INTERNAL_SYSCALL_ERROR_P): New define.
 	(INTERNAL_SYSCALL_ERRNO): Likewise.
 
 	* sysdeps/unix/sysv/linux/i386/profil-counter.h (profil_counter):
-	Add hack to prevent the compiler from clobbering the signal
-	context.
+	Add hack to prevent the compiler from clobbering the signal context.
 
 2002-10-11  Roland McGrath  <roland@redhat.com>
 
diff --git a/elf/dl-load.c b/elf/dl-load.c
index 1d10541f52..e1909ca6bf 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -916,29 +916,27 @@ _dl_map_object_from_fd (const char *name, int fd, struct filebuf *fbp,
 	      goto call_lose;
 	    }
 
-	  {
-	    struct loadcmd *c = &loadcmds[nloadcmds++];
-	    c->mapstart = ph->p_vaddr & ~(ph->p_align - 1);
-	    c->mapend = ((ph->p_vaddr + ph->p_filesz + GL(dl_pagesize) - 1)
-			 & ~(GL(dl_pagesize) - 1));
-	    c->dataend = ph->p_vaddr + ph->p_filesz;
-	    c->allocend = ph->p_vaddr + ph->p_memsz;
-	    c->mapoff = ph->p_offset & ~(ph->p_align - 1);
-
-	    /* Optimize a common case.  */
+	  c = &loadcmds[nloadcmds++];
+	  c->mapstart = ph->p_vaddr & ~(ph->p_align - 1);
+	  c->mapend = ((ph->p_vaddr + ph->p_filesz + GL(dl_pagesize) - 1)
+		       & ~(GL(dl_pagesize) - 1));
+	  c->dataend = ph->p_vaddr + ph->p_filesz;
+	  c->allocend = ph->p_vaddr + ph->p_memsz;
+	  c->mapoff = ph->p_offset & ~(ph->p_align - 1);
+
+	  /* Optimize a common case.  */
 #if (PF_R | PF_W | PF_X) == 7 && (PROT_READ | PROT_WRITE | PROT_EXEC) == 7
-	    c->prot = (PF_TO_PROT
-		       >> ((ph->p_flags & (PF_R | PF_W | PF_X)) * 4)) & 0xf;
+	  c->prot = (PF_TO_PROT
+		     >> ((ph->p_flags & (PF_R | PF_W | PF_X)) * 4)) & 0xf;
 #else
-	    c->prot = 0;
-	    if (ph->p_flags & PF_R)
-	      c->prot |= PROT_READ;
-	    if (ph->p_flags & PF_W)
-	      c->prot |= PROT_WRITE;
-	    if (ph->p_flags & PF_X)
-	      c->prot |= PROT_EXEC;
+	  c->prot = 0;
+	  if (ph->p_flags & PF_R)
+	    c->prot |= PROT_READ;
+	  if (ph->p_flags & PF_W)
+	    c->prot |= PROT_WRITE;
+	  if (ph->p_flags & PF_X)
+	    c->prot |= PROT_EXEC;
 #endif
-	  }
 	  break;
 
 	case PT_TLS:
diff --git a/sysdeps/unix/sysv/linux/i386/sysdep.h b/sysdeps/unix/sysv/linux/i386/sysdep.h
index ac7edb406c..851d91b69a 100644
--- a/sysdeps/unix/sysv/linux/i386/sysdep.h
+++ b/sysdeps/unix/sysv/linux/i386/sysdep.h
@@ -316,7 +316,7 @@ asm (".L__X'%ebx = 1\n\t"
     (int) resultvar; })
 
 #undef INTERNAL_SYSCALL_ERROR_P
-#define INTERNAL_SYSCALL_ERROR_P(val)	((val) >= 0xfffff001)
+#define INTERNAL_SYSCALL_ERROR_P(val)	((unsigned int) (val) >= 0xfffff001u)
 
 #undef INTERNAL_SYSCALL_ERRNO
 #define INTERNAL_SYSCALL_ERRNO(val)	(-(val))