diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2019-02-15 13:44:17 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2019-02-15 13:44:17 +0000 |
| commit | 365f05c7a5f16aaaec06465ab6c89247c66b4574 (patch) | |
| tree | 934f1d62a27b826a052aa84755683cb226127014 | |
| parent | 56a731d4ad319e473851893980e734b7ee42c1a0 (diff) | |
| download | glibc-365f05c7a5f16aaaec06465ab6c89247c66b4574.tar.gz glibc-365f05c7a5f16aaaec06465ab6c89247c66b4574.tar.xz glibc-365f05c7a5f16aaaec06465ab6c89247c66b4574.zip | |
Fix implicit-fallthrough warnings in tst-setjmp.c.
Building the testsuite with -Wextra (together with -Wno-cast-function-type -Wno-clobbered -Wno-expansion-to-defined -Wno-missing-field-initializers -Wno-old-style-declaration -Wno-shift-negative-value -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter, which reflect the set of -Wextra warnings for which glibc itself is not currently clean on x86_64) showed up implicit-fallthrough warnings in tst-setjmp.c. Those warnings appear to be false positives, arising from a function "jump" that calls longjmp not itself being marked as noreturn; thus, this patch adds the noreturn marking to that function to fix the warnings. Tested for x86_64. * setjmp/tst-setjmp.c (jump): Use __attribute__ ((__noreturn__)).
| -rw-r--r-- | ChangeLog | 4 | ||||
| -rw-r--r-- | setjmp/tst-setjmp.c | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog index d3560ade54..0c45e9a852 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2019-02-15 Joseph Myers <joseph@codesourcery.com> + + * setjmp/tst-setjmp.c (jump): Use __attribute__ ((__noreturn__)). + 2019-02-14 Jan Kratochvil <jan.kratochvil@redhat.com> * scripts/test_printers_common.py: Set TERM to a known harmless diff --git a/setjmp/tst-setjmp.c b/setjmp/tst-setjmp.c index e83e896ebe..b377393ecf 100644 --- a/setjmp/tst-setjmp.c +++ b/setjmp/tst-setjmp.c @@ -22,7 +22,7 @@ static jmp_buf env; static int last_value = -1, lose = 0; -static void +static __attribute__ ((__noreturn__)) void jump (int val) { longjmp (env, val); |