diff options
| author | Florian Weimer <fweimer@redhat.com> | 2018-12-01 21:43:36 +0100 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2018-12-01 22:41:46 +0100 |
| commit | 02cd5c1a8d033d7f91fea12a66bb44d1bbf85f76 (patch) | |
| tree | b30f94dace1c095ee797205034da5af99e7fd0cf | |
| parent | fc493bc9e6fe8ecdd00f79b9a8a3d4675137a602 (diff) | |
| download | glibc-02cd5c1a8d033d7f91fea12a66bb44d1bbf85f76.tar.gz glibc-02cd5c1a8d033d7f91fea12a66bb44d1bbf85f76.tar.xz glibc-02cd5c1a8d033d7f91fea12a66bb44d1bbf85f76.zip | |
support: Close original descriptors in support_capture_subprocess
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | support/support_capture_subprocess.c | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index e00d691d90..98c7ac761e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2018-12-01 Florian Weimer <fweimer@redhat.com> + + * support/support_capture_subprocess.c + (support_capture_subprocess): Check that pipe descriptors have + expected values. Close original pipe descriptors in subprocess. + 2018-12-01 Samuel Thibault <samuel.thibault@ens-lyon.org> [BZ #23032] diff --git a/support/support_capture_subprocess.c b/support/support_capture_subprocess.c index 6d2029e13b..93f6ea3102 100644 --- a/support/support_capture_subprocess.c +++ b/support/support_capture_subprocess.c @@ -59,8 +59,12 @@ support_capture_subprocess (void (*callback) (void *), void *closure) int stdout_pipe[2]; xpipe (stdout_pipe); + TEST_VERIFY (stdout_pipe[0] > STDERR_FILENO); + TEST_VERIFY (stdout_pipe[1] > STDERR_FILENO); int stderr_pipe[2]; xpipe (stderr_pipe); + TEST_VERIFY (stderr_pipe[0] > STDERR_FILENO); + TEST_VERIFY (stderr_pipe[1] > STDERR_FILENO); TEST_VERIFY (fflush (stdout) == 0); TEST_VERIFY (fflush (stderr) == 0); @@ -72,6 +76,8 @@ support_capture_subprocess (void (*callback) (void *), void *closure) xclose (stderr_pipe[0]); xdup2 (stdout_pipe[1], STDOUT_FILENO); xdup2 (stderr_pipe[1], STDERR_FILENO); + xclose (stdout_pipe[1]); + xclose (stderr_pipe[1]); callback (closure); _exit (0); } |