about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDavid Abdurachmanov <david.abdurachmanov@gmail.com>2019-04-09 13:25:29 +0200
committerPalmer Dabbelt <palmer@sifive.com>2019-04-25 10:53:08 -0700
commitdeacca0054a1c42151ac027171ef3c2aba6bc566 (patch)
treecd725f2c60bafcd8ebe21f6b62b7718cadff819d
parentb5ffdc48c20ae865b197b67e5a9068a528fbc198 (diff)
downloadglibc-deacca0054a1c42151ac027171ef3c2aba6bc566.tar.gz
glibc-deacca0054a1c42151ac027171ef3c2aba6bc566.tar.xz
glibc-deacca0054a1c42151ac027171ef3c2aba6bc566.zip
riscv: remove DL_RO_DYN_SECTION
While working on enabling D front-end (GDC) in GCC we noticed that
druntime was segfaulting if it is linked dynamically. This was tracked
to DL_RO_DYN_SECTION.

DL_RO_DYN_SECTION lines seem to be copied from MIPS file (which is the
only user of it), but the comment doesn't apply to RISC-V. There is no
such requirement in RISC-V ABI.

        [BZ#24484]
	* sysdeps/riscv/ldsodefs.h: Remove DL_RO_DYN_SECTION as it is not
	required by RISC-V ABI.
-rw-r--r--ChangeLog5
-rw-r--r--sysdeps/riscv/ldsodefs.h4
2 files changed, 5 insertions, 4 deletions
diff --git a/ChangeLog b/ChangeLog
index d735e1c437..100e8407fc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-04-25  David Abdurachmanov  <david.abdurachmanov@gmail.com>
+
+	[BZ#24484]
+	* sysdeps/riscv/ldsodefs.h (DL_RO_DYN_SECTION): Remove.
+
 2019-04-25  Florian Weimer  <fweimer@redhat.com>
 
 	benchtests: Enable BIND_NOW if configured with --enable-bind-now.
diff --git a/sysdeps/riscv/ldsodefs.h b/sysdeps/riscv/ldsodefs.h
index f46cf4158e..5ec607e867 100644
--- a/sysdeps/riscv/ldsodefs.h
+++ b/sysdeps/riscv/ldsodefs.h
@@ -38,10 +38,6 @@ struct La_riscv_retval;
 				       struct La_riscv_retval *,	\
 				       const char *);
 
-/* The RISC-V ABI specifies that the dynamic section has to be read-only.  */
-
-#define DL_RO_DYN_SECTION 1
-
 #include_next <ldsodefs.h>
 
 #endif