diff options
| author | Andreas Schwab <schwab@suse.de> | 2016-06-16 12:44:29 +0200 |
|---|---|---|
| committer | Andreas Schwab <schwab@suse.de> | 2016-06-30 13:55:36 +0200 |
| commit | 73fb56a4d51fd4437e4cde6dd3c8077a610f88a8 (patch) | |
| tree | a03c812f3c385ba07c9f1a4191face6df630e362 | |
| parent | 3631c9742a8740777e09d9e8f6f5e6cccaf7340c (diff) | |
| download | glibc-73fb56a4d51fd4437e4cde6dd3c8077a610f88a8.tar.gz glibc-73fb56a4d51fd4437e4cde6dd3c8077a610f88a8.tar.xz glibc-73fb56a4d51fd4437e4cde6dd3c8077a610f88a8.zip | |
Return proper status from _nss_nis_initgroups_dyn (bug 20262)
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | nis/nss_nis/nis-initgroups.c | 16 |
2 files changed, 18 insertions, 5 deletions
diff --git a/ChangeLog b/ChangeLog index f7803ee322..9131b1f889 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2016-06-30 Andreas Schwab <schwab@suse.de> + + [BZ #20262] + * nis/nss_nis/nis-initgroups.c (_nss_nis_initgroups_dyn): Return + NSS_STATUS_SUCCESS when done. Return NSS_STATUS_TRYAGAIN when out + of memory. + 2016-06-29 H.J. Lu <hongjiu.lu@intel.com> [BZ #18645] diff --git a/nis/nss_nis/nis-initgroups.c b/nis/nss_nis/nis-initgroups.c index dec385cec7..0368667cf6 100644 --- a/nis/nss_nis/nis-initgroups.c +++ b/nis/nss_nis/nis-initgroups.c @@ -266,7 +266,7 @@ _nss_nis_initgroups_dyn (const char *user, gid_t group, long int *start, tmpbuf = __alloca (buflen); - do + while (1) { while ((status = internal_getgrent_r (&grpbuf, tmpbuf, buflen, errnop, @@ -275,8 +275,11 @@ _nss_nis_initgroups_dyn (const char *user, gid_t group, long int *start, tmpbuf = extend_alloca (tmpbuf, buflen, 2 * buflen); if (status != NSS_STATUS_SUCCESS) - goto done; - + { + if (status == NSS_STATUS_NOTFOUND) + status = NSS_STATUS_SUCCESS; + goto done; + } g = &grpbuf; if (g->gr_gid != group) @@ -304,7 +307,11 @@ _nss_nis_initgroups_dyn (const char *user, gid_t group, long int *start, newgroups = realloc (groups, newsize * sizeof (*groups)); if (newgroups == NULL) - goto done; + { + status = NSS_STATUS_TRYAGAIN; + *errnop = errno; + goto done; + } *groupsp = groups = newgroups; *size = newsize; } @@ -316,7 +323,6 @@ _nss_nis_initgroups_dyn (const char *user, gid_t group, long int *start, } } } - while (status == NSS_STATUS_SUCCESS); done: while (intern.start != NULL) |