diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2018-09-12 20:31:24 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2018-09-12 20:31:24 +0000 |
| commit | 221e4babca17b363df2c56e839572e9f7ab7d127 (patch) | |
| tree | e5e202bc388f02ce3561e56fcbe31faaa3cb4d9e | |
| parent | 3e08ff544b86834cd24795de159f16b8c65c7b8f (diff) | |
| download | glibc-221e4babca17b363df2c56e839572e9f7ab7d127.tar.gz glibc-221e4babca17b363df2c56e839572e9f7ab7d127.tar.xz glibc-221e4babca17b363df2c56e839572e9f7ab7d127.zip | |
Include most of elf/ modules-names in modules-names-tests.
I'm testing a patch to let the compiler expand calls to floor in libm as built-in function calls as much as possible, instead of calling __floor, so that no architecture-specific __floor inlines are needed, and then to arrange for non-inlined calls to end up calling __floor, as done with sqrt and __ieee754_sqrt. This shows up elf/tst-relsort1mod2.c calling floor, which must not be converted to a call to __floor. Now, while an IS_IN (libm) conditional could be added to the existing conditionals on such redirections in include/math.h, the _ISOMAC conditional ought to suffice (code in other glibc libraries shouldn't be calling floor or sqrt anyway, as they aren't provided in libc and the other libraries don't link with libm). But while tests are mostly now built with _ISOMAC defined, test modules in modules-names aren't unless also listed in modules-names-tests. As far as I can see, all the modules in modules-names in elf/ are in fact parts of tests and so listing them in modules-names-tests is appropriate, so they get built with something closer to the headers used for user code, except in a few cases that actually rely on something from internal headers. This patch duly sets modules-names-tests there accordingly (filtering out those tests that fail to build without internal headers). Tested for x86_64, and with build-many-glibcs.py. * elf/Makefile (modules-names-tests): New variable.
| -rw-r--r-- | ChangeLog | 4 | ||||
| -rw-r--r-- | elf/Makefile | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 696e456957..5bbf568a27 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2018-09-12 Joseph Myers <joseph@codesourcery.com> + + * elf/Makefile (modules-names-tests): New variable. + 2018-09-12 Szabolcs Nagy <szabolcs.nagy@arm.com> * NEWS: Mention log2 improvements. diff --git a/elf/Makefile b/elf/Makefile index cd0771307f..4a4ca84ed1 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -274,6 +274,10 @@ modules-names = testobj1 testobj2 testobj3 testobj4 testobj5 testobj6 \ tst-nodelete-dlclose-dso tst-nodelete-dlclose-plugin \ tst-main1mod tst-libc_dlvsym-dso tst-absolute-sym-lib \ tst-absolute-zero-lib tst-big-note-lib +# Most modules build with _ISOMAC defined, but those filtered out +# depend on internal headers. +modules-names-tests = $(filter-out ifuncmod% tst-libc_dlvsym-dso tst-tlsmod%,\ + $(modules-names)) ifeq (yes,$(have-mtls-dialect-gnu2)) tests += tst-gnu2-tls1 |