about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2015-10-15 23:59:54 +0000
committerJoseph Myers <joseph@codesourcery.com>2015-10-15 23:59:54 +0000
commit15306e38888f770e548538a956e279b019654443 (patch)
treee85dcae2f63fbe471de4195ed7253aebae509c52
parent2b714df5d8977132b6bd8a2b338b1a523bb00d9f (diff)
downloadglibc-15306e38888f770e548538a956e279b019654443.tar.gz
glibc-15306e38888f770e548538a956e279b019654443.tar.xz
glibc-15306e38888f770e548538a956e279b019654443.zip
Remove NPTL configure errors based on top-level configure tests.
sysdeps/nptl/configure.ac has code to give errors if certain tests in
the top-level configure failed.  However, all those failure conditions
also produce errors in the top-level configure, so the errors in the
NPTL configure are completely redundant; this patch removes them.

(As suggested in
<https://sourceware.org/ml/libc-alpha/2015-10/msg00510.html>, I think
the top-level tests in question can be completely removed as
unnecessary given the version tests.  But even without that there is
clearly no point in duplicating code that gives an error if the test
fails.)

Tested for x86_64 (testsuite, and that installed shared libraries are
unchanged by the patch).

	* sysdeps/nptl/configure.ac: Do not give errors based on the
	results of top-level configure tests.
	* sysdeps/nptl/configure: Regenerated.
-rw-r--r--ChangeLog4
-rw-r--r--sysdeps/nptl/configure9
-rw-r--r--sysdeps/nptl/configure.ac9
3 files changed, 4 insertions, 18 deletions
diff --git a/ChangeLog b/ChangeLog
index 652fa5a9e6..ad3f64f9e4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2015-10-15  Joseph Myers  <joseph@codesourcery.com>
 
+	* sysdeps/nptl/configure.ac: Do not give errors based on the
+	results of top-level configure tests.
+	* sysdeps/nptl/configure: Regenerated.
+
 	* configure.ac (libc_cv_Bgroup): Remove configure test.
 	* configure: Regenerated.
 	* config.make.in (have-Bgroup): Remove variable.
diff --git a/sysdeps/nptl/configure b/sysdeps/nptl/configure
index cce07b35d2..18bae6bbc0 100644
--- a/sysdeps/nptl/configure
+++ b/sysdeps/nptl/configure
@@ -1,14 +1,5 @@
 # This file is generated from configure.ac by Autoconf.  DO NOT EDIT!
 
-if test "x$libc_cv_gcc___thread" != xyes; then
-  as_fn_error $? "compiler support for __thread is required" "$LINENO" 5
-fi
-
-if test "x${libc_cv_visibility_attribute}" != xyes ||
-   test "x${libc_cv_broken_visibility_attribute}" != xno; then
-  as_fn_error $? "working compiler support for visibility attribute is required" "$LINENO" 5
-fi
-
 
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for forced unwind support" >&5
 $as_echo_n "checking for forced unwind support... " >&6; }
diff --git a/sysdeps/nptl/configure.ac b/sysdeps/nptl/configure.ac
index 58032155cd..1ee3d576be 100644
--- a/sysdeps/nptl/configure.ac
+++ b/sysdeps/nptl/configure.ac
@@ -1,15 +1,6 @@
 dnl configure fragment for new libpthread implementation.
 GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
 
-if test "x$libc_cv_gcc___thread" != xyes; then
-  AC_MSG_ERROR(compiler support for __thread is required)
-fi
-
-if test "x${libc_cv_visibility_attribute}" != xyes ||
-   test "x${libc_cv_broken_visibility_attribute}" != xno; then
-  AC_MSG_ERROR(working compiler support for visibility attribute is required)
-fi
-
 dnl Iff <unwind.h> is available, make sure it is the right one and it
 dnl contains struct _Unwind_Exception.
 AC_CACHE_CHECK(dnl