diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-11-01 11:56:53 -0200 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-11-06 17:37:57 -0200 |
| commit | d83da3a4cebcf77e34593b86112dfad332808dae (patch) | |
| tree | 625e7c99cd0b38a0c685bc3d7b23631dcbe8db85 | |
| parent | 6a4235f129b75ad9963ae93d9f386b8b366cb65a (diff) | |
| download | glibc-d83da3a4cebcf77e34593b86112dfad332808dae.tar.gz glibc-d83da3a4cebcf77e34593b86112dfad332808dae.tar.xz glibc-d83da3a4cebcf77e34593b86112dfad332808dae.zip | |
Optimize sighold implementation
This patch simplifies sighold a bit by removing an extra sigprocmask and using SIG_BLOCK (which union of the current set and the set argument). Checked on x86_64-linux-gnu. * signal/sighold.c (sighold): Optimize implementation. Signed-off-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Reviewed-by: Zack Weinberg <zackw@panix.com>
| -rw-r--r-- | ChangeLog | 2 | ||||
| -rw-r--r-- | signal/sighold.c | 10 |
2 files changed, 4 insertions, 8 deletions
diff --git a/ChangeLog b/ChangeLog index 9861b97e8f..8355074f7f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2017-11-06 Adhemerval Zanella <adhemerval.zanella@linaro.org> + * signal/sighold.c (sighold): Optimize implementation. + * sysdeps/unix/sysv/linux/sigqueue.c (__sigqueue): Asssume __NR_rt_sigqueueinfo. diff --git a/signal/sighold.c b/signal/sighold.c index 2e32e4718a..955ac5b0fb 100644 --- a/signal/sighold.c +++ b/signal/sighold.c @@ -26,14 +26,8 @@ sighold (int sig) { sigset_t set; - /* Retrieve current signal set. */ - if (__sigprocmask (SIG_SETMASK, NULL, &set) < 0) - return -1; - - /* Add the specified signal. */ + sigemptyset (&set); if (sigaddset (&set, sig) < 0) return -1; - - /* Set the new mask. */ - return __sigprocmask (SIG_SETMASK, &set, NULL); + return __sigprocmask (SIG_BLOCK, &set, NULL); } |