about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndreas Jaeger <aj@suse.de>2001-01-23 09:29:53 +0000
committerAndreas Jaeger <aj@suse.de>2001-01-23 09:29:53 +0000
commitb0ed91aecf0184aaa8ace2dc0e32ae318cfac7b4 (patch)
treea6cdb7af12e99585af9b79225da220bf04f8cf28
parentecf525cdd773f314895374542c2168fda0483c26 (diff)
downloadglibc-b0ed91aecf0184aaa8ace2dc0e32ae318cfac7b4.tar.gz
glibc-b0ed91aecf0184aaa8ace2dc0e32ae318cfac7b4.tar.xz
glibc-b0ed91aecf0184aaa8ace2dc0e32ae318cfac7b4.zip
Update.
	* elf/dl-load.c (_dl_init_paths): Don't use strdupa in function
	arguments.  Reported by Jiri Kubicek <kubicek@bitsmart.com>,
	closes PR libc/2039.
-rw-r--r--ChangeLog4
-rw-r--r--FAQ9
-rw-r--r--FAQ.in9
-rw-r--r--elf/dl-load.c3
4 files changed, 14 insertions, 11 deletions
diff --git a/ChangeLog b/ChangeLog
index 442869d54a..5f52569f90 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2001-01-23  Andreas Jaeger  <aj@suse.de>
 
+	* elf/dl-load.c (_dl_init_paths): Don't use strdupa in function
+	arguments.  Reported by Jiri Kubicek <kubicek@bitsmart.com>,
+	closes PR libc/2039.
+
 	* manual/install.texi (Tools for Compilation): Change required
 	binutils version.
 
diff --git a/FAQ b/FAQ
index ccf04124d2..8d655fdaab 100644
--- a/FAQ
+++ b/FAQ
@@ -261,10 +261,9 @@ understand all the features of ELF, including weak and versioned symbols.
 The static library can be compiled with less featureful tools, but lacks key
 features such as NSS.
 
-For Linux or Hurd, you want binutils 2.8.1.0.23, 2.9.1, or 2.9.1.0.15 or
-higher.  These are the only versions we've tested and found reliable.  Other
-versions after 2.8.1.0.23 may work but we don't recommend them, especially
-not when C++ is involved.  Earlier versions do not work at all.
+For Linux or Hurd, you want binutils 2.10.1 or higher.  These are the only
+versions we've tested and found reliable.  Other versions may work but we
+don't recommend them, especially not when C++ is involved.
 
 Other operating systems may come with system tools that have all the
 necessary features, but this is moot because glibc hasn't been ported to
@@ -285,7 +284,7 @@ at:
 
 <ftp://ftp.netwinder.org/users/p/philb/egcs-1.1.1pre2-diff-981126>
 
-Binutils 2.9.1.0.16 or later is also required.
+Binutils 2.10.1 or later is also required.
 
 
 1.7.	Do I need some more things to compile the GNU C Library?
diff --git a/FAQ.in b/FAQ.in
index cf3a0a1f00..666965aa4d 100644
--- a/FAQ.in
+++ b/FAQ.in
@@ -85,10 +85,9 @@ understand all the features of ELF, including weak and versioned symbols.
 The static library can be compiled with less featureful tools, but lacks key
 features such as NSS.
 
-For Linux or Hurd, you want binutils 2.8.1.0.23, 2.9.1, or 2.9.1.0.15 or
-higher.  These are the only versions we've tested and found reliable.  Other
-versions after 2.8.1.0.23 may work but we don't recommend them, especially
-not when C++ is involved.  Earlier versions do not work at all.
+For Linux or Hurd, you want binutils 2.10.1 or higher.  These are the only
+versions we've tested and found reliable.  Other versions may work but we
+don't recommend them, especially not when C++ is involved.
 
 Other operating systems may come with system tools that have all the
 necessary features, but this is moot because glibc hasn't been ported to
@@ -107,7 +106,7 @@ at:
 
 <ftp://ftp.netwinder.org/users/p/philb/egcs-1.1.1pre2-diff-981126>
 
-Binutils 2.9.1.0.16 or later is also required.
+Binutils 2.10.1 or later is also required.
 
 ??	Do I need some more things to compile the GNU C Library?
 
diff --git a/elf/dl-load.c b/elf/dl-load.c
index b18089c05e..e8112b10bb 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -667,6 +667,7 @@ _dl_init_paths (const char *llp)
     {
       size_t nllp;
       const char *cp = llp;
+      char *llp_tmp = strdupa (llp);
 
       /* Decompose the LD_LIBRARY_PATH contents.  First determine how many
 	 elements it has.  */
@@ -684,7 +685,7 @@ _dl_init_paths (const char *llp)
 	_dl_signal_error (ENOMEM, NULL,
 			  N_("cannot create cache for search path"));
 
-      (void) fillin_rpath (strdupa (llp), env_path_list.dirs, ":;",
+      (void) fillin_rpath (llp_tmp, env_path_list.dirs, ":;",
 			   __libc_enable_secure, "LD_LIBRARY_PATH", NULL);
 
       if (env_path_list.dirs[0] == NULL)