about summary refs log tree commit diff
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2022-03-16 08:43:48 -0700
committerH.J. Lu <hjl.tools@gmail.com>2022-03-16 08:48:36 -0700
commit564f7ae7b45ee00e8e35499e462d28ad45c56022 (patch)
tree10d5a1cd7cd6ab3b10ce695eac3db978f62d798e
parent7a5c440102d4ec7fafd9bbd98eca9bd90ecaaafd (diff)
downloadglibc-564f7ae7b45ee00e8e35499e462d28ad45c56022.tar.gz
glibc-564f7ae7b45ee00e8e35499e462d28ad45c56022.tar.xz
glibc-564f7ae7b45ee00e8e35499e462d28ad45c56022.zip
benchtests: Use "=" instead of ":=" [BZ #28970]
Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches
to bench and benchset.  This fixes BZ #28970.
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
-rw-r--r--benchtests/Makefile6
1 files changed, 4 insertions, 2 deletions
diff --git a/benchtests/Makefile b/benchtests/Makefile
index d513b29903..8dfca592fd 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o
 extra-objs += $(bench-extra-objs)
 others-extras = $(bench-extra-objs)
 
-binaries-bench := $(addprefix $(objpfx)bench-,$(bench))
+# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more
+# benches.
+binaries-bench = $(addprefix $(objpfx)bench-,$(bench))
 extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench)))
-binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset))
+binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset))
 extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset)))
 binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc))
 extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))