diff options
| author | Aurelien Jarno <aurelien@aurel32.net> | 2016-08-03 00:22:44 +0200 |
|---|---|---|
| committer | Aurelien Jarno <aurelien@aurel32.net> | 2016-08-03 00:22:44 +0200 |
| commit | 30f926d3b3dcb74c038155715ed341d5c4b334eb (patch) | |
| tree | 58572af183eb37e658b9acc89396ab371242f988 | |
| parent | ee71e5b6dd6a21e981ad0fa74359e066f5a8b359 (diff) | |
| download | glibc-30f926d3b3dcb74c038155715ed341d5c4b334eb.tar.gz glibc-30f926d3b3dcb74c038155715ed341d5c4b334eb.tar.xz glibc-30f926d3b3dcb74c038155715ed341d5c4b334eb.zip | |
powerpc: fix ifunc-sel.h fix asm constraints and clobber list
As pointer out on the mailing list, the inline assembly code in sysdeps/powerpc/ifunc-sel.h doesn't have a list of clobbered registers and used wrong constraints. This patch fixes that. I verified it doesn't introduce any change in the generated code. Changelog: * sysdeps/powerpc/ifunc-sel.h (ifunc_sel): Add "11", "12", "cr0" to the clobber list. Use "i" constraint instead of "X". (ifunc_one): Add "12" to the clobber list. Use "i" constraint instead of "X".
| -rw-r--r-- | ChangeLog | 4 | ||||
| -rw-r--r-- | sysdeps/powerpc/ifunc-sel.h | 6 |
2 files changed, 8 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog index b66ba7ae77..0b294c85bc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,10 @@ * sysdeps/powerpc/ifunc-sel.h (ifunc_sel): Replace beqlr instructions by beq instructions jumping to the end of the function. + * sysdeps/powerpc/ifunc-sel.h (ifunc_sel): Add "11", "12", "cr0" to the + clobber list. Use "i" constraint instead of "X". + (ifunc_one): Add "12" to the clobber list. Use "i" constraint instead + of "X". 2016-08-02 Joseph Myers <joseph@codesourcery.com> diff --git a/sysdeps/powerpc/ifunc-sel.h b/sysdeps/powerpc/ifunc-sel.h index 79d110fef1..ac589bd3c0 100644 --- a/sysdeps/powerpc/ifunc-sel.h +++ b/sysdeps/powerpc/ifunc-sel.h @@ -26,7 +26,8 @@ ifunc_sel (int (*f1) (void), int (*f2) (void), int (*f3) (void)) "addi %0,%0,%4-1b@l\n\t" "2:" : "=r" (ret) - : "X" (&global), "X" (f1), "X" (f2), "X" (f3)); + : "i" (&global), "i" (f1), "i" (f2), "i" (f3) + : "11", "12", "cr0"); return ret; } @@ -41,7 +42,8 @@ ifunc_one (int (*f1) (void)) "addis %0,%0,%1-1b@ha\n\t" "addi %0,%0,%1-1b@l" : "=r" (ret) - : "X" (f1)); + : "i" (f1) + : "12"); return ret; } #endif |