diff options
author | Stefan Liebler <stli@linux.vnet.ibm.com> | 2018-04-19 12:32:50 +0200 |
---|---|---|
committer | Stefan Liebler <stli@linux.vnet.ibm.com> | 2018-04-19 12:32:50 +0200 |
commit | da796524f8d64df3113e3c538adf285cf3ba041c (patch) | |
tree | cdd001a99d94653ed07ea79d5144ddd5a4e5f730 | |
parent | f55a4fdefb00837f2e2a77c04792e69e888ead3e (diff) | |
download | glibc-da796524f8d64df3113e3c538adf285cf3ba041c.tar.gz glibc-da796524f8d64df3113e3c538adf285cf3ba041c.tar.xz glibc-da796524f8d64df3113e3c538adf285cf3ba041c.zip |
Use volatile global counters in test-tgmath.c.
If build with -Os on s390x, the test-tgmath fails with: float functions not called often enough (-10000) Within compile_testf(), the counter (count_float) is saved before the complex functions are called. Afterwards the saved counter differs to the current-counter. But the tests with the complex functions do not increment count_float! Instead count_float is saved to a register before calling totalorder and totalordermag which both increment count_float. The compiler is allowed to do that as totalorderf and totalordermagf is declared with __attribute__ ((__const__)) in math/bits/mathcalls.h. Thus this patch adjusts the global counters to be volatile. Then count_float is saved after totalordermag. ChangeLog: * math/test-tgmath.c (count_double, count_float, count_ldouble, count_cdouble, count_cfloat, count_cldouble): Use volatile int.
-rw-r--r-- | ChangeLog | 6 | ||||
-rw-r--r-- | math/test-tgmath.c | 12 |
2 files changed, 12 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog index ec19da47f2..df941db962 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2018-04-19 Stefan Liebler <stli@linux.vnet.ibm.com> + + * math/test-tgmath.c (count_double, count_float, + count_ldouble, count_cdouble, count_cfloat, + count_cldouble): Use volatile int. + 2018-04-19 Samuel Thibault <samuel.thibault@ens-lyon.org> * sysdeps/mach/hurd/i386/Makefile [$(subdir) = conform] diff --git a/math/test-tgmath.c b/math/test-tgmath.c index 6d8e7fde4e..2b0787cd4a 100644 --- a/math/test-tgmath.c +++ b/math/test-tgmath.c @@ -45,12 +45,12 @@ complex float fz; complex double dz; complex long double lz; -int count_double; -int count_float; -int count_ldouble; -int count_cdouble; -int count_cfloat; -int count_cldouble; +volatile int count_double; +volatile int count_float; +volatile int count_ldouble; +volatile int count_cdouble; +volatile int count_cfloat; +volatile int count_cldouble; #define NCALLS 134 #define NCALLS_INT 4 |