about summary refs log tree commit diff
diff options
context:
space:
mode:
authorZack Weinberg <zackw@panix.com>2016-11-14 14:25:11 -0500
committerZack Weinberg <zackw@panix.com>2016-11-14 14:25:11 -0500
commit8888eb5e6d0ca664671c312a1409166114699519 (patch)
treea57b467a91f55fd47373fd8ca7c852691f00be43
parent9601d3ad787729c74f3971814426fc9e64571d80 (diff)
downloadglibc-8888eb5e6d0ca664671c312a1409166114699519.tar.gz
glibc-8888eb5e6d0ca664671c312a1409166114699519.tar.xz
glibc-8888eb5e6d0ca664671c312a1409166114699519.zip
Fix build-and-build-again bug in sunrpc tests.
rpcgen will error out if the file it's asked to create already exists.
Several other rules in sunrpc/Makefile take care to delete rpcgen-
generated files before creating them, but rpcgen-tests doesn't, which
can lead to spurious test failures in an incremental rebuild.

	* sunrpc/Makefile (rpcgen-tests): Delete the .out file before
	creating or re-creating it.
-rw-r--r--sunrpc/Makefile1
1 files changed, 1 insertions, 0 deletions
diff --git a/sunrpc/Makefile b/sunrpc/Makefile
index 99e5c3ccf8..9e805fbb00 100644
--- a/sunrpc/Makefile
+++ b/sunrpc/Makefile
@@ -233,6 +233,7 @@ $(objpfx)thrsvc: $(common-objpfx)linkobj/libc.so $(shared-thread-library)
 
 ifeq ($(run-built-tests),yes)
 $(rpcgen-tests): $(objpfx)%.out: %.x $(objpfx)rpcgen
+	-rm -f $@
 	$(built-program-cmd) -c $< -o $@; \
 	$(evaluate-test)
 endif