From 6131e36f8a838aa54ed687dc08b387bceeb70fdf Mon Sep 17 00:00:00 2001 From: okan Date: Mon, 12 Aug 2019 00:52:36 +0000 Subject: Fix regression from r1.107 (lost a return); kettenis@ pointed out the high potential for a use-after-free (true!) where kn@ ran into the regression using an app that actually exercised the XGrabPointer() failure path. --- menu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/menu.c b/menu.c index d0d3802..60633fc 100644 --- a/menu.c +++ b/menu.c @@ -129,6 +129,7 @@ menu_filter(struct screen_ctx *sc, struct menu_q *menuq, const char *prompt, CurrentTime) != GrabSuccess) { XftDrawDestroy(mc.xftdraw); XDestroyWindow(X_Dpy, mc.win); + return(NULL); } XGetInputFocus(X_Dpy, &focuswin, &focusrevert); -- cgit 1.4.1