summary refs log tree commit diff
path: root/group.c
Commit message (Collapse)AuthorAgeFilesLines
* Now that a group knows its screen, only pass down the group_ctx.okan2014-09-081-16/+16
|
* Add screen_ctx to group_ctx, and populate on init.okan2014-09-071-0/+1
|
* Get rid of a redundant array of groups per screen; we already have aokan2014-09-071-8/+22
| | | | link to the group queue for each screen.
* Rework group names: stash the group name inside the group_ctx as opposedokan2014-09-061-52/+2
| | | | | | to having to manage an array outside in screen_ctx for group names and shortcuts. Simplifies (and moves bits for) reading, and constructing data for, EWMH's _NET_DESKTOP_NAMES.
* Merge group_menu into mousefunc_menu_group.okan2014-09-011-36/+3
|
* Since the flatting out of sc->group_names is only for settingokan2014-08-251-24/+2
| | | | | NET_DESKTOP_NAMES, merge the helper into xu_ewmh_net_desktop_names, where we actually set the property.
* Implement _NET_WM_STATE_STICKY, bound to CM-s by default; allows anyokan2014-08-251-0/+2
| | | | | | | client to 'stick' to all desktops (ewmh speak) or groups - this currently has the same affect as setting a client's group to 'nogroup', with the exception that the client can also be in a group, so when un-sticking, the client will go back to its original group/desktop.
* gc->hidden has never consistently kept track of a group's state;okan2014-08-241-29/+18
| | | | | | | | | | group_show() and group_hide() are not the only ways a group can change state - if all clients in a group are either hidden or unhidden, then that group's state should change, as well as the various EWMH ways. Instead of trying to keep track in a wide variety of places, simply query the clients in a group before needing to take action based on the group's state. Solves long standing confusion of when a group is hidden or not.
* Fix nogroup regression, where nogroup became an actual group - theokan2014-08-221-12/+11
| | | | | | | | | | symantics between cwm groups and ewmh got in the way. Ensure a client that wants to be in nogroup stays in nogroup (thus stays in view), even when (re)reading NET_WM_DESKTOP. Paritially reverts patchset 644 (2014-02-07 13:09 PST) which deals with a NULL cc->group. All to be revisited when NET_WM_STATE_STICKY hits cwm. Reported by many; testing and ok phessler.
* Purely mechanical; unify 'num', 'no' and 'shortcut'.okan2014-08-201-19/+19
|
* Split off group window restacking.okan2014-08-201-4/+15
|
* fix a misleading comment and function nameokan2014-08-201-5/+5
|
* Pull highstack from group_ctx (and useless calculations of); in the oneokan2014-08-191-16/+9
| | | | | place that we use highstack, replace that usage with a local variable (for now until stacking is done properly).
* Get rid of nhidden in group_ctx; it actually never reported correctlyokan2014-08-181-7/+5
| | | | | | | since nhidden wasn't incremented nor decremeted in all the right places, thus confusing matters. We don't need to carry a count around, so just use a local variable in the one place we need one to supply XRestackWindows().
* Make sure we cycle through existing client's group membership and setokan2014-02-081-0/+9
|\ | | | | | | | | the hidden state on the group; important to know group hidden state after a re-exec or restart of cwm (as easily seen in group menu).
* | Replace a few hand rolled loops with like tailq loops.okan2014-02-081-16/+12
| |
* | If _NET_WM_DESKTOP is set to -1 during client creation, place the client intookan2014-02-071-28/+12
| | | | | | | | | | | | | | | | | | | | | | | | group 0 (nogroup); solves problem initially discovered by oga@nicotinebsd with tint2. A clientmessage *after* client creation already handles this case. Go further and assign every client to a group; in non-sticky mode, group 0 (nogroup) and sticky mode, the active group. In both cases, autogroup will override the group assignment. Removing a group from a client always places the client back into group 0 (nogroup). Autogroup can also assign a client to group 0 (nogroup) to keep a client always visible (unless of course one opts to hide all clients).
* | correct arguments and drop the cast.okan2014-01-241-1/+1
| | | | | | | | sanity check by oga@nicotinebsd
* | Add a function that adds an entry to a menuq, normalizing a common codeokan2014-01-201-9/+2
| | | | | | | | path; from Tiago Cunha.
* | Stash Class and WM Hints in client_ctxokan2013-12-111-3/+3
| |
* | a few err->errx since we don't have error messages here; from Tiago Cunhaokan2013-10-171-3/+3
| |
* | unify type; no changeokan2013-10-031-1/+1
| |
* | simplify atom handling; allows us to limit to one round-trip to serverokan2013-07-151-3/+3
| | | | | | | | for gathering Atoms.
* | since the root and event window are the same in the case of a buttonokan2013-07-091-4/+1
| | | | | | | | | | | | | | event on the screen's root window, there's no need to pass down the entire XButtonEvent event, at least to group_menu(), the only callback which takes an argument at this point; instead use the already populated screen.
* | replace a few (x)malloc with (x)calloc to prevent potential integerokan2013-07-081-2/+2
| | | | | | | | overflows; from Tiago Cunha
* | remove group in client_delete directly.okan2013-05-061-11/+0
| |
* | type fixokan2013-04-301-2/+1
| |
* | add conf_ignore and move group_make_autogroup to conf_autogroup to match.okan2013-04-171-21/+0
| |
* | reverse logic to make it like the othersokan2013-04-081-8/+4
| |
* | consistencyokan2013-04-081-0/+1
| |
* | zap stray whitespaceokan2013-04-051-1/+1
| |
* | put back r1.68 which allows an empty group to be sticky; behaviorokan2013-01-131-1/+5
| | | | | | | | | | | | change noticed by Thomas Pfaff and diagnosis why we need to group_setactive in this case by Alexander Polakov. replace XXX with a useful comment.
* | set the initial group to '1', missed by recent off-by-one groupokan2013-01-101-1/+1
| | | | | | | | | | | | numbering re-work; discovered the hard way by sthen@. ok sthen@
* | after we toggle a group hidden, it makes no sense to set it as activeokan2013-01-011-5/+1
| | | | | | | | | | | | | | | | (in sticky or non-stick mode), regardless of existing clients assigned to that group; oga marked this bit XXX in -r1.34 for it didn't seem make sense then either. pulled from a diff from from Alexander Polakov.
* | make num of groups no longer off-by-one; from Alexander Polakovokan2013-01-011-5/+5
| | | | | | | | | | | | note that a re-exec of cwm will not rewrite the group number atom of *existing* clients, so they will remain off-by-one until each client has its atom updated, or of course a restart of X.
* | replace client highlight with a client flagokan2012-12-171-6/+4
| |
* | create and use menuq_clear() helper; from Tiago Cunhaokan2012-12-171-4/+1
| |
* | specific last match for autogroup; few iterations with Kent Spillner.okan2012-11-291-6/+8
| |
* | sortokan2012-11-091-1/+1
| |
* | fix some warnings; inspired by a diff from Thordur Bjornsson.okan2012-11-081-2/+2
| |
* | get rid of the xfree() wrapper around free(); from Tiago Cunha.okan2012-11-071-3/+3
| |
* | replace with xu_getprop wrapper used everywhere else.okan2012-09-091-12/+6
| |
* | remove a redundant assignment and another one up.okan2012-07-081-2/+1
| |
* | re-implement atom handing; makes for a normalized and more consistentokan2012-07-031-38/+17
| | | | | | | | separation between cwm and ewmh. seen by a few.
* | get rid of more stray lines/spacesokan2012-05-161-2/+2
| |
* | fix commentokan2012-05-161-2/+3
| |
* | check if we're in the group already, else multiple calls tookan2011-12-291-1/+3
| | | | | | | | | | | | | | | | | | | | group_movetogroup() on one client will still increment nhidden if the group is hidden. found the hard way by Thomas Jeunet and fix from Alexander Polakov - thanks to both! ok oga@
* | use xfree instead of free since strings is allocated with xmalloc; fromokan2011-10-121-1/+1
| | | | | | | | | | | | dhill ok oga@
* | move client to group (movetogroup) and hide client only if group isokan2011-09-191-1/+5
| | | | | | | | | | | | already hidden (suggested behavior from Alexander Polakov). ok sthen oga
* | repair groupcycle (broke after cycle-in-group support added more flags);okan2011-09-131-5/+5
| | | | | | | | | | | | found by and fix from Thomas Pfaff. ok oga@