summary refs log tree commit diff
path: root/group.c
Commit message (Collapse)AuthorAgeFilesLines
* cvsimportokan2017-02-101-1/+1
|\ | | | | | | | | | | * refs/heads/master: Fix group hidden state when a client wants to be on all desktops on start; reported by Vadim Vygonets with diff, but another approach was taken. Call client_resize instead of client_move after client_placecalc since the size may also change.
| * Fix group hidden state when a client wants to be on all desktops on start;okan2017-02-101-1/+1
| | | | | | | | reported by Vadim Vygonets with diff, but another approach was taken.
* | cvsimportokan2016-10-241-18/+18
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: (34 commits) Make it clear these are flags. Remove duplicate check that strsubmatch() already does; while here, fix a comment. Sprinkle __func__ in appropriate error messages. Get rid of 'matchname'; it's too surprising to have the menu change during client search as different potential str matches are cycled through. If there's interest, the only string that doesn't exist in the listing is the window's class - that can be added of course, but it makes the line too long imho. clean up search_match_client(); no behaviour change Refactor callbacks to take a void * so as to not try and generalize into client_ctx in keypress and buttonpress event handlers; pass appropriate *ctx's based on context. remove another unused proto Rename 2 kbfunc to match closer to what they do Add an argument to the callbacks to pass the xevent context, button or key press. This allows to remove a few hacks to duplicate functions only for behaviour changes; now differing behaviours are pushed down to the callback. Also will allow for previously unavailable actions to be bind-able down the road. Check the ptr bounds in the new client during cycling, since not all actions do ptrsave, such as restoring client geometry; adapted from a diff by Vadim Vygonets. More accurate to say 'toggle', rather than 'select', for group[n]/nogroup. Add CM-a for 'nogroup' (CM-0 stays for now); update manpage to reflect. Stash wmname into conf. When removing xrandr regions, ensure clients are within the bounds of the screen; adapted from an ancient diff from Sviatoslav Chagaev. Things in this area will likely change, but put this in so it works now and serves as a reminder. Calculate client nameqlen in client_setname(), the only place it's needed/used. Turn CALMWM_NGROUPS define into variable, ngroups. Start simplifying menu code; and in turn, remove a cursor no longer needed. Defaults are split between defines and conf_init(); normalize these, as well as give 'sticky' groups its own variable. For both kb and mouse move, it is possible to grab a client and move it completely off the screen/region; instead, if the pointer is outside of the client bounds, warp the pointer to the closest edge before moving. client_ptrwarp should not deal with unhiding or raising clients (non ptr requests); most callers do this already - deal with the few that do not. client_ptrwarp becomes a simple wrapper (setpos) but it will be expanded. ...
| * Sprinkle __func__ in appropriate error messages.okan2016-10-241-3/+3
| |
| * Refactor callbacks to take a void * so as to not try and generalize intookan2016-10-181-11/+11
| | | | | | | | | | | | | | | | client_ctx in keypress and buttonpress event handlers; pass appropriate *ctx's based on context. While here, limit some globals, replace defines with appropriate variables and fix some naming.
| * Turn CALMWM_NGROUPS define into variable, ngroups.okan2016-10-041-4/+4
| |
* | cvsimportokan2016-09-141-10/+3
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: Some clients fail to setup hints at all, so initalize for them; fallout from r1.218 switching to malloc - clearly missed this case. Fix-up a few simple uses of client_current(): check CLIENT_ACTIVE flag instead of relying on curcc. init label Limit mouse resize to hints within the client; matches kbd resize behaviour. Switch to just malloc since we need initialize most everything anyway. change 'sticky' to 'stick' to toggle client stickiness (seems the default binding worked for everyone for a long time!); conflict with group sticky found by Ali Farzanrad - thanks! Simplify group_holds_only_hidden(); from Vadim Vygonets. Simplify toggling flags; from Vadim Vygonets. Do not draw borders on ignored clients when returning from fullscreen; from Vadim Vygonets. Remove redundant minimum client size adjustment (minw and minh are always positive since r1.214); from Vadim Vygonets.
| * Simplify group_holds_only_hidden(); from Vadim Vygonets.okan2016-09-021-10/+3
| |
* | cvsimportokan2015-11-121-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: more client vs screen context differences If a client sets hints, honor them for kb resize requests, just like we do for mouse based resize requests. Move kb pointer movement out of the kbfunc_client_moveresize since it's got nothing to do with clients, thus doing flags work causes lots of waste and almost useless jumpy pointer movements; while here, split out move and resize since they share almost no code, just like mouse client move/resize; factor out amount and factor. Still wonder why this is here, but it works now. pledge "stdio rpath proc exec" cwm before main event loop, after init/setup - mostly for menu building. Partial revert of replacing screen_area() with region_find(); until a fix for a regression is found; this bug has been around for a long time it seems, but this change exposed it. Likely need to track clients in to and out of regions. Use position on root to figure out region. Start cleaning up name vs function differences; replace magic numbers. Clean up unused defines. Extend region to include both view and work areas; switch to region_find() which no longer needs to recalculate gap each time a client (or menu) is created or altered. If no RandR, fall back to display dimensions while building regions instead of during execution.
| * Start cleaning up name vs function differences; replace magic numbers.okan2015-11-101-1/+1
| |
* | cvsimportokan2015-08-281-60/+90
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: (21 commits) Lost fix from r1.112; add comment. Mechanical change: group->gc Add consistent checks against NULL. Move client cycle grab/ungrab into a more relevant place; while here, update comments about why we need to grab/ungrab the keyboard. Re-add lost chunk in group_cycle from r1.113. Further simplify _NET_WM_DESKTOP handling using new group_assign(). oops; remove left over debug print Allowing sending a valid 'nogroup' (0) group_ctx to group_assign() (since we init all groups), though assigning the client's group to NULL for 'sticky'; use this simplification in a few places (others to follow). Split out sticky mode checks and the restoring of a client's group and _NET_WM_DESKTOP from the config-based auto-grouping; no (intentional) behavior changes. Needed for further work in cleaning up this area. Implement _NET_CLIENT_LIST_STACKING (from Thomas Admin), but bottom-to-top order, as per spec (notified Thomas as well). Don't allow freeze operations on fullscreen (consistent with what fullscreen does). Sort _NET_WM_STATE Atoms like the spec. Move CLIENT_STICKY logic from client hide/unhide to group hide/unhide; rationale being that clients should be able to hide/unhide independently of group switching. Add Xkb modifier to ignore mask; from Alexander Polakov. Fix whitespace. Add client freeze extension to _NET_WM_STATE Atom, allowing flag to persist. As usual with new Atoms, requires X restart. _NET_WM_STATE_STICKY implies only sticky at the group/desktop level, not position and size; based on discussion with a few. Instead of special casing the 'term' and 'lock' commands, go back to keeping them hidden; showing them has apparently caused confusion/angst. Leave command list order from .cwmrc alone; remove sort. Bring group and client cycle closer together. ...
| * Mechanical change: group->gcokan2015-08-271-6/+6
| |
| * Re-add lost chunk in group_cycle from r1.113.okan2015-08-271-0/+3
| |
| * Further simplify _NET_WM_DESKTOP handling using new group_assign().okan2015-08-251-6/+3
| |
| * oops; remove left over debug printokan2015-08-251-2/+0
| |
| * Allowing sending a valid 'nogroup' (0) group_ctx to group_assign()okan2015-08-251-5/+6
| | | | | | | | | | | | (since we init all groups), though assigning the client's group to NULL for 'sticky'; use this simplification in a few places (others to follow).
| * Split out sticky mode checks and the restoring of a client's group andokan2015-08-251-32/+45
| | | | | | | | | | _NET_WM_DESKTOP from the config-based auto-grouping; no (intentional) behavior changes. Needed for further work in cleaning up this area.
| * Move CLIENT_STICKY logic from client hide/unhide to group hide/unhide;okan2015-08-231-4/+8
| | | | | | | | | | rationale being that clients should be able to hide/unhide independently of group switching.
| * Bring group and client cycle closer together.okan2015-08-211-20/+34
| |
* | cvsimportChristian Neukirchen2015-07-011-3/+2
|\|
| * replace assert usageokan2015-06-281-3/+2
| |
* | cvsimportokan2015-03-291-1/+1
|\|
| * Introduce a xreallocarray and convert a few xcalloc instances that dookan2015-03-281-1/+1
| | | | | | | | not require zero'ing.
* | cvsimportChristian Neukirchen2015-01-221-1/+2
|\|
| * Switch to limits.h; replace MAXPATHLEN and MAXHOSTNAMELEN with PATH_MAXokan2015-01-191-1/+2
| | | | | | | | | | | | and HOST_NAME_MAX+1, respectively. ok doug@
* | cvsimportokan2014-10-081-14/+13
|\|
| * make group_init work like other *_init'sokan2014-10-081-14/+13
| |
* | cvsimportokan2014-09-271-29/+13
|\|
| * these have nothing to do with 'sticky', but rather group membership; rename.okan2014-09-271-5/+2
| |
| * Pass just the group to group_setactive instead of the screen and anokan2014-09-271-12/+8
| | | | | | | | index which then needed to be found in a queue.
| * Update _NET_CURRENT_DESKTOP with the screen's group_active->num.okan2014-09-231-3/+3
| |
| * Move stuff that doesn't belong in group_init; while here, explicitlyokan2014-09-231-11/+2
| | | | | | | | initialize hideall and cycling.
* | cvsimportokan2014-09-181-41/+65
|\|
| * Use a similarly named check as sticky for hidden check in a group.okan2014-09-171-9/+5
| |
| * Introduce a check to see if a group holds only 'sticky' clients and useokan2014-09-171-1/+14
| | | | | | | | | | | | | | | | this check to decide if a group is virtually empty. Rationale: if a group contains *only* 'sticky' clients, it should be skipped while cycling through groups. Apply similar logic to the group menu. Based on an idea from phessler@, who also tested another version.
| * name the group client queue appropriately, like other queuesokan2014-09-081-10/+10
| |
| * Now that a group knows its screen, only pass down the group_ctx.okan2014-09-081-16/+16
| |
| * Add screen_ctx to group_ctx, and populate on init.okan2014-09-071-0/+1
| |
| * Get rid of a redundant array of groups per screen; we already have aokan2014-09-071-8/+22
| | | | | | | | link to the group queue for each screen.
* | cvsimportChristian Neukirchen2014-09-071-177/+64
|\|
| * Rework group names: stash the group name inside the group_ctx as opposedokan2014-09-061-52/+2
| | | | | | | | | | | | to having to manage an array outside in screen_ctx for group names and shortcuts. Simplifies (and moves bits for) reading, and constructing data for, EWMH's _NET_DESKTOP_NAMES.
| * Merge group_menu into mousefunc_menu_group.okan2014-09-011-36/+3
| |
| * Since the flatting out of sc->group_names is only for settingokan2014-08-251-24/+2
| | | | | | | | | | NET_DESKTOP_NAMES, merge the helper into xu_ewmh_net_desktop_names, where we actually set the property.
| * Implement _NET_WM_STATE_STICKY, bound to CM-s by default; allows anyokan2014-08-251-0/+2
| | | | | | | | | | | | | | client to 'stick' to all desktops (ewmh speak) or groups - this currently has the same affect as setting a client's group to 'nogroup', with the exception that the client can also be in a group, so when un-sticking, the client will go back to its original group/desktop.
| * gc->hidden has never consistently kept track of a group's state;okan2014-08-241-29/+18
| | | | | | | | | | | | | | | | | | | | group_show() and group_hide() are not the only ways a group can change state - if all clients in a group are either hidden or unhidden, then that group's state should change, as well as the various EWMH ways. Instead of trying to keep track in a wide variety of places, simply query the clients in a group before needing to take action based on the group's state. Solves long standing confusion of when a group is hidden or not.
| * Fix nogroup regression, where nogroup became an actual group - theokan2014-08-221-12/+11
| | | | | | | | | | | | | | | | | | | | symantics between cwm groups and ewmh got in the way. Ensure a client that wants to be in nogroup stays in nogroup (thus stays in view), even when (re)reading NET_WM_DESKTOP. Paritially reverts patchset 644 (2014-02-07 13:09 PST) which deals with a NULL cc->group. All to be revisited when NET_WM_STATE_STICKY hits cwm. Reported by many; testing and ok phessler.
| * Purely mechanical; unify 'num', 'no' and 'shortcut'.okan2014-08-201-19/+19
| |
| * Split off group window restacking.okan2014-08-201-4/+15
| |
| * fix a misleading comment and function nameokan2014-08-201-5/+5
| |
| * Pull highstack from group_ctx (and useless calculations of); in the oneokan2014-08-191-16/+9
| | | | | | | | | | place that we use highstack, replace that usage with a local variable (for now until stacking is done properly).