about summary refs log tree commit diff
path: root/client.c
Commit message (Collapse)AuthorAgeFilesLines
* cvsimportop2023-03-221-1/+1
|\ | | | | | | | | * refs/heads/master: cwm: fix a semi-transparency border issue with some applications
| * cwm: fix a semi-transparency border issue with some applicationsop2023-03-221-1/+1
| | | | | | | | | | | | | | | | When running with a compositor the border of some applications (firefox, chromium, zathura...) is not rendered correctly. Initializing the highest significant bits of the color fixes it. diff from Julien Blanchard (julien at typed-hole [dot] org); ok okan@
* | cvsimportokan2022-02-271-6/+8
|\| | | | | | | | | | | | | | | | | | | | | * refs/heads/master: cycling fix: when no client is active, warp pointer to last active; from Walter Alejandro Iglesias. whitespace Fix spelling of some unused MWM hints; from Sean C. Farley. Add group-last command that shows only the previously active group; ok okan Allow bare numbers for key and mouse bindings; taken from similar support in other parse.y's; from Leon Fischer <lfischer@airmail.cc>. sync parse.y changes from base; ok naddy@ Do not attempt to grab keys without a keycode; this incidentally allows XF86 keys support.
| * whitespaceokan2022-02-261-1/+1
| |
| * Fix spelling of some unused MWM hints; from Sean C. Farley.okan2022-02-261-5/+7
| | | | | | | | While here, flesh out the rest of the MWM hints.
* | cvsimportkn2021-04-221-0/+4
|\| | | | | | | | | * refs/heads/master: Keep pointer within window on maximize/fullscreen toggle
| * Keep pointer within window on maximize/fullscreen togglekn2021-04-221-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Spawn a window, maximize it in any way, move the cursor to a window border that is not on the screen's edge and unmaximize again: While the window goes back the cursor stays at the screen's edge, i.e. focus is lost to the underlaying window. Moving, resizing, tiling or snapping windows in any way always moves the cursor along iff needed, e.g. using MS-[hjkl] to move a small window from the center to the edge keeps the cursor within window borders -- no matter what you do with the keyboard, focus stays on that window. Make CM-f, CM-m, CM-equal and CMS-equal (default bindings) for toggling full-screen mode, maximization, vertical maximization and horizontal maximization of the current window drag the cursor along if needed as well. OK okan kmos dv
* | cvsimportLeah Neukirchen2020-05-141-226/+147
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: Fixed memory leak in xu_get_strprop. Prevent out of boundary write with configuration files in which too many quoted arguments are stored for other window managers. Allow configuring a percentage window size of the master window during htile/vtile actions. From Uwe Werler, with a few manpage tweaks. zap stray tabs Instead of using _NET_ACTIVE_WINDOW on restart, use the pointer location to determine what client to set active. Reduces a round trip for every window. Add support for SIGINT/SIGTERM. Simplify conditional construct. Trim event_mask to those that the root window actually needs. No need to lookup current client early; move to right before it is needed. Recommit 1.259, but now with TAILQ_FOREACH_SAFE. Revert previous. Causes a crash as reported by Tom Murphy. Simplify list markup. Plug two memory leaks. Also get rid of a variable that is no longer necessary. Remove ColormaskChange from event-mask since there's no event handler. Unrelated style fixes, consistency changes and sorting, appropriate dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
| * Allow configuring a percentage window size of the master window duringokan2020-04-161-2/+4
| | | | | | | | htile/vtile actions. From Uwe Werler, with a few manpage tweaks.
| * Instead of using _NET_ACTIVE_WINDOW on restart, use the pointer locationokan2020-03-241-11/+1
| | | | | | | | | | to determine what client to set active. Reduces a round trip for every window.
| * Recommit 1.259, but now with TAILQ_FOREACH_SAFE.tim2020-03-161-9/+11
| | | | | | | | | | | | | | | | | | | | | | From and OK okan@ Original commit message: Plug two memory leaks. Also get rid of a variable that is no longer necessary. OK okan@
| * Revert previous. Causes a crash as reported by Tom Murphy.tim2020-03-141-9/+7
| |
| * Plug two memory leaks. Also get rid of a variable that is no longertim2020-03-131-7/+9
| | | | | | | | | | | | necessary. OK okan@
| * Remove ColormaskChange from event-mask since there's no event handler.okan2020-02-281-2/+2
| |
| * Unrelated style fixes, consistency changes and sorting, appropriateokan2020-02-271-210/+137
| | | | | | | | | | dosage/removal of wrappers, simplification of name queue, client cycle joins other kb/mb bound functions.
* | cvsimportokan2020-02-071-6/+0
|\| | | | | | | | | | | | | | | * refs/heads/master: Allow the 'empty' group clients to be window-{h,v}tile'd. Map ('5') and allow mod5mask (altgr) as a modifier. add, then use, xvasprintf, checking for appropriate return. Ensure the pointer stays within client bounds after a window 'snap' (to edge).
| * Allow the 'empty' group clients to be window-{h,v}tile'd.okan2020-02-071-6/+0
| | | | | | | | Behaviour (or lack there of) noticed by Raf Czlonka.
* | cvsimportokan2019-03-111-29/+30
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: (23 commits) Check the atom type on propertynotify before iterating. use screen_find() for xrandr crtc changes Find the managed screen from the parent window for client_current(). Print window id in hex; while here, remove unnecessary newline. Similar to keypress event, fetch the screen from the event root window in the buttonpress handler; bail if we don't manage the screen. Allows us to find the current client based on the screen/event root. extend verbose logging for key/button events [keypress event] turns out we've been checking the wrong window for a matching client thus always falling back to client_current(); while the current client is problaby right in most cases, use event's subwindow (not window) to find the client. Bail early if this event came to us from a screen we don't manage. This is result of us grabing all keybindings off the root window instead of selectively. add parans for readibility Teach client_current() to use a screen to find the current client instead of iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current(). check cc->gc directly zip extra lines gc clientq inside groups, instead use the better maintained one per-screen shuffle deck chairs: rename group actions to match intent for clarity same thing as screen_find() Separate out the menu window from the client resize/move geom window; in each case, create and destroy on-demand. Isolate more menu specific code. fix a few misplaced (and misnamed) ewmh root window functions _NET_WORKAREA needs ngroups, so screen_update_geometry() needs to come after conf_group(). simplify xftcolor config Tie group number and name together during config. Move the group index (desktop number) check to the only 2 callers that require checking due to ewmh. ...
| * Teach client_current() to use a screen to find the current client instead ofokan2019-03-071-5/+12
| | | | | | | | | | iterating over all (fallback if no screen provided for now). Initially convert trivial uses of client_current().
| * check cc->gc directlyokan2019-03-071-4/+2
| |
| * gc clientq inside groups, instead use the better maintained one per-screenokan2019-03-071-7/+12
| |
| * Selectively hide and show clients based on state; merge client_unhide() andokan2019-02-281-13/+4
| | | | | | | | client_show().
* | cvsimportLeah Neukirchen2019-02-251-27/+38
|\| | | | | | | | | | | | | | | | | | | * refs/heads/master: Add 'group-close-[n]' action to close all windows within specified group. simplify screen 'area' usage for initial client placement restore order from before r1.248 (vtile/vtile containment changes). Rename internal functions to delinate between client remove, delete and xproto delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs. Limit vtile/htile actions to clients fully within the screen of master client. fix missing includes
| * simplify screen 'area' usage for initial client placementokan2019-02-231-13/+8
| |
| * restore order from before r1.248 (vtile/vtile containment changes).okan2019-02-221-2/+1
| |
| * Rename internal functions to delinate between client remove, delete and xprotookan2019-02-221-2/+2
| | | | | | | | | | delete; 'window-close' is now the proper action, but 'window-delete' as an alias will remain until more interesting changes require breaking configs.
| * Limit vtile/htile actions to clients fully within the screen of master client.okan2019-02-221-12/+29
| | | | | | | | from Charles A Daniels.
* | cvsimportokan2018-11-141-15/+27
|\| | | | | | | | | | | | | | | * refs/heads/master: Stop asking for events (NoEventMask) from menu window once done with the menu (we don't destroy it, only unmap). Allow 'transientfor' clients to inherit group and bwidth either during init or via property notify events. Previously only the flags were set but nothing was in the path to apply said flags and/or bwidth. Required slight of re-orgnaization of client_init. merge from base, from sashan@: Use the original client border width to adjust initial placement of clients containing {P,US}Position requests where they are explicitly set to 'ignore' in cwmrc(5); clients are unaware that their border will be altered (removed in this case) when calcuating position and thus end up a factor of their original border width off once mapped by cwm(1). cwm(1) will essentially shift the client to the edge if the original request's position and border match.
| * Allow 'transientfor' clients to inherit group and bwidth either during init orokan2018-11-131-16/+21
| | | | | | | | | | | | via property notify events. Previously only the flags were set but nothing was in the path to apply said flags and/or bwidth. Required slight of re-orgnaization of client_init.
| * Use the original client border width to adjust initial placement of clientsokan2018-11-081-0/+7
| | | | | | | | | | | | | | | | | | | | | | containing {P,US}Position requests where they are explicitly set to 'ignore' in cwmrc(5); clients are unaware that their border will be altered (removed in this case) when calcuating position and thus end up a factor of their original border width off once mapped by cwm(1). cwm(1) will essentially shift the client to the edge if the original request's position and border match. Window offset noticed by at least Andre Stoebe via bugs@, and others since (and likely before). Thanks!
* | cvsimportokan2018-02-061-46/+38
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: (28 commits) Use screen's saved view instead of re-querying the server. Slightly expand and expose verbose debugging. add debugging for x events Add a simple debug logging mechanism. Simplification; use asprintf where appropriate now. Use func attributes where appropriate. Fix wins comparison declaration since it's unsigned from XQueryTree(). Generate name_to_func[] in a clean and readable fashion. Shrink tier[] by one after removing matchname in r1.55. If the requested group number is invalid, bail but don't kill cwm. Quick fix: exit after a failed execvp in u_spawn instead; previously we did in u_exec, but the introduction of re-exec'ing the previous invocation of cwm if 'exec_wm' failed missed the 'exec' failing path. Will likely split out as a proper fix. Only exec the fallback when in CWM_EXEC_WM state. Typo, from Julien Steinhauser. Convert menu-exec-wm from an abritrary exec menu, into a config-based menu from which one may configure (wm <name> <path_and_args>) (and choose) specific window managers to replace the running one. 'wm cwm cwm' is included by default. As done for buttonrelease, work specific un-cycling and un-highlighting actions into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change. Merge group_toggle_membership_leave into the buttonrelease event and only do border work for a group/ungroup action. add helper function client_show to bring together like actions for unhide/raise Add support for re-exec'ing with SIGHUP; equivalent to the already built-in 'restart' function. Use poll and XNextEvent to replace XNextEvent blocking inside the x11 event handler. zap stray that snuck in ...
| * Use screen's saved view instead of re-querying the server.okan2018-02-061-9/+4
| |
| * As done for buttonrelease, work specific un-cycling and un-highlighting actionsokan2017-12-291-21/+1
| | | | | | | | | | | | | | | | | | into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change. Additionally, like we do for group membership, grab the keyboard only when required for cycling.
| * add helper function client_show to bring together like actions for unhide/raiseokan2017-12-291-0/+9
| |
| * Fix a few comments and while here, wrap some long lines.okan2017-12-221-16/+10
| |
| * Add support for _NET_WM_STATE_SKIP_PAGER and _NET_WM_STATE_SKIP_TASKBAR; eerilyokan2017-12-191-1/+15
| | | | | | | | | | | | | | close to cwm's 'ignore'. Roughly based on an initial diff from Walter Alejandro Iglesias, but with support for both Atoms and without cwm-based bindings.
* | cvsimportokan2017-05-091-9/+27
|\| | | | | | | | | | | | | | | | | * refs/heads/master: drop obsolete comment Alter callbacks to take a struct instead of a growing number of arguments; greatly simplifies upcoming work. Ensure clients stay within the viewable bounds on placement, even with empty borders; based on a patch from Vadim Vygonets. Clean up, unify and accurately calculate edge distance with client move/resize actions, so as to not lose windows off the edge. Switch bwidth type; unfortunately X11 is inconsistent.
| * Ensure clients stay within the viewable bounds on placement, even with emptyokan2017-05-051-8/+8
| | | | | | | | borders; based on a patch from Vadim Vygonets.
| * Clean up, unify and accurately calculate edge distance with client move/resizeokan2017-05-011-0/+18
| | | | | | | | | | | | actions, so as to not lose windows off the edge. inspired by diffs (and feedback) from Vadim Vygonets.
| * Switch bwidth type; unfortunately X11 is inconsistent.okan2017-04-261-5/+5
| |
* | cvsimportokan2017-04-251-9/+13
|\| | | | | | | | | | | | | | | | | | | | | * refs/heads/master: The r1.36 menuq_add() conversion did this one wrong; fix by reverting to the original code which adds to resultentry list, as opposed to the wrong one in menuq_add(). Fixes crash noticed by at least Rickard Gustafsson. Remove 'noresult' (and simplify) as it does nothing and makes the logic around it needless. History doesn't show what this might have been used for in future iterations. search_match_path() isn't supposed to return anything. Move queue init to caller so it's only called once in a few cases. sort Raise the previously focused window, instead of the previous window in the cycle list; seems to match behaviour of other wm's; from Walter Alejandro Iglesias. For {h,v}tile, instead of keeping the master client's {h,v} geometry, expand it to %50 of the area, then fill in the remaining space with the other clients in the same group; from Gerrit Meyerheim.
| * sortokan2017-04-241-10/+10
| |
| * Raise the previously focused window, instead of the previous window in theokan2017-04-241-1/+3
| | | | | | | | | | cycle list; seems to match behaviour of other wm's; from Walter Alejandro Iglesias.
| * For {h,v}tile, instead of keeping the master client's {h,v} geometry, expand itokan2017-04-241-0/+2
| | | | | | | | | | | | | | to %50 of the area, then fill in the remaining space with the other clients in the same group; from Gerrit Meyerheim. support from ajacoutot.
* | cvsimportokan2017-02-101-1/+1
|\| | | | | | | | | | | * refs/heads/master: Fix group hidden state when a client wants to be on all desktops on start; reported by Vadim Vygonets with diff, but another approach was taken. Call client_resize instead of client_move after client_placecalc since the size may also change.
| * Call client_resize instead of client_move after client_placecalc since the sizeokan2017-02-061-1/+1
| | | | | | | | | | | | may also change. from Vadim Vygonets
* | cvsimportokan2017-01-051-11/+13
|\| | | | | | | | | | | * refs/heads/master: Ensure client stays inbound on key-based resize; based on logic existing in key-based client move; from Vadim Vygonets. When a window has a user or program specified position, ensure the edge of the final position is at least viewable and warp'able by the difference of bwidth; prevents mapping windows completely off the virtual screen.
| * When a window has a user or program specified position, ensure the edge of theokan2016-12-191-11/+13
| | | | | | | | | | final position is at least viewable and warp'able by the difference of bwidth; prevents mapping windows completely off the virtual screen.
* | cvsimportChristian Neukirchen2016-12-161-4/+4
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/heads/master: stray newlines Add search_print_text(), a default callback for mi->print in menu_filter(). While here, normalize the remaining search_print_* argument paramters. Consistent use of menuq_add for ssh menu. Now that dim.{x,y} are available early, use them before requiring a MotionNotify event. Set dim.{x,y} during client_init and update on resize, instead of (re)calculating only when applying hints. 'window-search' is spelled 'menu-window'; the former snuck in during the conversion('menu-window' already existed and was properlly documented); found the hard way by sthen@ while trying to convert. Fold unbinding functions into one for each, key and mouse; plugs a leak when unbinding a mouse button bound to a command. use the correct type Tame the number of 'exec' and 'path' search_match wrappers. No functional change now, though more can likely go later, losing the (paritally complete or incomplete/broken) argument completion bits. Switch ssh menu to search_match_text; like group/window/cmd menus, use only a substring match. The previous matching is only intended for the exec menus. Change 'menu-window' to display all windows; then add 'menu-window-hidden' for the previous behaviour of 'menu-window'. 'menu-window' becomes the default binding; use 'bind-mouse "1" menu-window-hidden' to restore old behaviour for those who prefer. Normalize bind function names, based on a few categories: window, group, menu and pointer. Use an additional check with lstat(2) when d_type is unknown. revert previous; upcoming changes will hopefully deal with these more naturally. Add a wrapper based upon xevent handlers around client move/resize for key and mouse bindings. Define callbacks, then default bindings. Reorganize for upcoming changes. Remove the (8) default bindings for pointer move since they conflict with default bindings for emacs, which wins; the feature remains and can be bound to whatever users wish with cwmrc(5).
| * stray newlinesokan2016-12-061-1/+0
| |