summary refs log tree commit diff
path: root/client.c
Commit message (Collapse)AuthorAgeFilesLines
* alter -r1.145 getsizehints to deal with clients that don't haveokan2013-11-271-35/+29
| | | | WM_NORMAL_HINTS.
* simplify/unfoldokan2013-11-271-5/+3
|
* Rewrite active/inactive client handling in client_setactive();okan2013-11-271-50/+28
| | | | | | | | | | | client_leave() served no real purpose, likewise no reason to handle LeaveNotify events since an EnterNotify will process the next active client (and we don't have anything important to process anyway), so xev_handle_leavenotify() goes as well. Allows a simplification of client_mtf() and client_cycle_leave() for clarity. While here, unify a few client_current() checks. No intended behaviour change.
* Alter the r1.35 of event.c race fix. Remove the forward looking eventokan2013-11-121-10/+1
| | | | | | | | | | | | queue check (removing the need for a server grab/ungrab) - if the client is going away, let it fall all the way through to a DestroyNotify event. There's no longer a need for us to manually destroy a client ourselves (removing yet another server grab/ungrab). Instead, when the UnmapNotify event is synthetic, simply set the state to Withdrawn (as per ICCCM), else Iconic (in our case 'hidden'). Verified with test case from the 2009 race which was the original reason for r1.35 of event.c.
* Put back the border draw call in client_resize; since we are adding andokan2013-11-111-0/+2
| | | | | | removing the border on maximized clients we need to redraw. Also noticed by Tim van der Molen
* stash WMProtocols in flagsokan2013-11-081-5/+5
|
* quick keyboard focus fix for clients that neither populate wmhints nor ↵okan2013-11-051-1/+2
| | | | wmprotocols, like rdesktop; focus needs to be re-visited
* The only reason we need to keep XSizeHints in our client_ctx is forokan2013-11-021-30/+37
| | | | | flags, so just add one to hints; consolidates sizehints and shrinks. Additionally don't abuse PSize for XGetWMNormalHints() failures.
* x/y from XSizeHints are obsolete (and have been for a long time), sookan2013-11-011-4/+2
| | | | | instead use x/y from XWindowAttributes when USPosition|PPosition are set.
* re-add support for WM_TAKE_FOCUS, and additionally this time only callokan2013-11-011-8/+17
| | | | | | XSetInputFocus() for clients that have the InputHint; latter fix discovered by Valery Masiutsin with a PoC patch - solves keyboard input focus loss for java apps.
* A client_delete should behave differently depending on whether theokan2013-10-251-7/+9
| | | | | | | triggering event was unmap (with pending destroy) log destroy; we only need to grab/ungrab the server lock, set WithdrawnState and XRemoveFromSaveSet clients coming from an unmap event - doing so for clients coming from destroy are already gone, hence we generate errors.
* revert 1.138 (WM_TAKE_FOCUS) for nowokan2013-10-201-2/+0
|
* Using xu_btn_ungrab() buttons during client_leave doesn't work (errorokan2013-10-191-5/+0
| | | | | | | BadValue) when the modifier is already AnyModifier . Instead alter xu_btn_ungrab() to ungrab AnyButton/AnyModifier and call it only when a client is coming into focus in client_setactive(), instead of iterating over ignore mods - matches how we handle key grabs.
* I believe we redraw the border in too many cases; likely a leftover fromokan2013-10-191-3/+0
| | | | | | | | | the cc->pwin days - don't redraw on every unhide, resize, and mouse move/resize Expose event (note, all Expose events trigger a redraw anyway). Tested with some finicky X apps I could think of, though I'm sure others will find more - if so, and they 'lose' the border, please report!
* For clients that support WM_TAKE_FOCUS in their WM_PROTOCOLS property, sendokan2013-10-191-0/+2
| | | | a ClientMessage event.
* unify type; no changeokan2013-10-031-1/+1
|
* collapse linesokan2013-07-151-2/+1
|
* simplify atom handling; allows us to limit to one round-trip to serverokan2013-07-151-6/+6
| | | | for gathering Atoms.
* move synthetic responses and have client_msg only work with WM_PROTOCOLS,okan2013-06-101-5/+40
| | | | since that's all ClientMessageEvent is for anyway.
* alter conf_grab(_kbd) to first ungrab AnyKey/AnyModifier, then proceedokan2013-05-231-1/+1
| | | | | | | | to grab keys in keybindingq. we don't need to ungrab/grab on every addition to the queue, just once with a complete keybindingq; simplify grabbing keys per screen (during init) and during a MappingNotify. while here, change conf_grab_{kbd,mouse} to require only a Window.
* add support for _NET_WM_STATE_MAXIMIZED_{HORZ,VERT}; from Alexander Polakov.okan2013-05-201-0/+5
| | | | | while I'm unsure of the final look of _NET_WM_STATE, there's no reason to delay this support.
* - switch border colors to Xftokan2013-05-191-4/+4
| | | | | | | | | - merge border/menu color structures/functions since they now both use Xft - switch xu_xorcolor to operating on XftColor instead of just XRenderColor (basically adding pixel) - if color name allocation fails, revert back to default (this, along with font validation should occur during config parse, but we don't have screens setup yet - likely to change at some point)
* use XGetWMProtocols and simplify WM_PROTOCOL handlingokan2013-05-191-18/+15
|
* new -> initokan2013-05-111-1/+1
|
* remove group in client_delete directly.okan2013-05-061-3/+3
|
* mechanical xu_{get,set}state -> xu_{get,set}_wm_state changeokan2013-04-171-5/+5
|
* slightly rework WM_STATE set/get to make it less ambigious; will be more clearokan2013-04-171-7/+11
| | | | on what needs to change to make it right in the end.
* only a window is required to set WM_STATE. also un-confuse xu_ptr_getposokan2013-04-141-1/+1
| | | | | by using 'win' instead of 'rootwin' so as not to imply only the root window is queried, rather any window.
* we handle WM_STATE here, so remove misleading comment.okan2013-04-121-1/+0
|
* we already set window state in client_hide or client_unhide right before, sookan2013-04-121-1/+0
| | | | there's no need to do it again.
* zap stray whitespaceokan2013-04-051-2/+2
|
* - no reason to breakout ClassHints work, so fold into client_{new,delete},okan2013-04-031-23/+15
| | | | | | but keep _MOTIF_WM_HINTS separate. - simplify fetching app/class hint. - fix _MOTIF_WM_HINTS Atom type.
* move XUngrabServer to the end of client_new() to avoid races where clients,okan2013-04-031-3/+3
| | | | | | | | such as those using sdl, attempt to manage the clients themselves when the clients aren't fully ready. other wm's grab the xserver during the whole client setup process, so match. behavior found by jsg.
* add per-group vert/horiz tiling support; introduces 2 new bind commands,okan2013-01-081-0/+118
| | | | 'vtile' and 'htile'; from Alexander Polakov.
* teach screen_find_xinerama() about gap and adjust (simplify) callers;okan2013-01-081-22/+11
| | | | menu becomes gap-aware for free.
* fix menu/client placement in panning setups; XineramaQueryScreens givesokan2013-01-071-0/+2
| | | | | us the width of the psuedo screen, but here we need the edge instead (xmax/ymax); just re-use w/h here for now.
* use cc->bwidth in client_vmax since we've yet to reset it (matchesokan2013-01-061-1/+1
| | | | client_hmax); from Jan Stary
* rename {h,v}max functions for consistency; from Jan Staryokan2013-01-041-2/+2
|
* get rid of struct colorokan2013-01-041-4/+4
|
* re-work client_snapcalc() so it takes client and edge dimensions withokan2013-01-021-8/+6
| | | | | | snapdist; allows for simplier snap calculations. required for an upcoming diff for honoring gap.
* have screen_find_xinerama() return struct geom *reliably* instead ofokan2013-01-021-64/+26
| | | | XineramaScreenInfo; simplifies goop around the callers.
* more variable consistencyokan2013-01-021-20/+20
|
* info->xine, for consistent variable namesokan2013-01-021-7/+7
|
* replace emptystring with strdup here as well so we know we are free'ingokan2013-01-011-6/+3
| | | | a malloc'd variable everytime; from Tiago Cunha
* make num of groups no longer off-by-one; from Alexander Polakovokan2013-01-011-1/+1
| | | | | | note that a re-exec of cwm will not rewrite the group number atom of *existing* clients, so they will remain off-by-one until each client has its atom updated, or of course a restart of X.
* cmap -> colormap in client_ctxokan2012-12-171-2/+2
|
* replace client highlight with a client flagokan2012-12-171-4/+3
|
* make client_mtf staticokan2012-12-171-3/+2
|
* current_client() returns _curcc, so use it where appropriateokan2012-12-171-6/+6
|
* sortokan2012-11-091-1/+1
|