diff options
author | oga <oga> | 2009-01-17 18:41:50 +0000 |
---|---|---|
committer | oga <oga> | 2009-01-17 18:41:50 +0000 |
commit | fa87ef4a9e6131597d86b0d3e76cd2e7b6911bcd (patch) | |
tree | babdf0da910b8fd6085519bc0e948719b0f61032 /calmwm.h | |
parent | 399253a4ff975c3858b9bba1db8e7aca15860399 (diff) | |
download | cwm-fa87ef4a9e6131597d86b0d3e76cd2e7b6911bcd.tar.gz cwm-fa87ef4a9e6131597d86b0d3e76cd2e7b6911bcd.tar.xz cwm-fa87ef4a9e6131597d86b0d3e76cd2e7b6911bcd.zip |
Finally fix the really annoying race where if you rapidly switch groups several
times you'd end up losing clients (thinking they had gone away). From the ICCCM (which should not be read without a stiff drink in hand, I made this mistake so you don't have to): to request a window to be withdrawn one should send a synthetic UnmapRequest event when iconified. To request iconification one should just unmap the window. The ICCM further recommends that the synthetic event should just be taken as a cue to withdraw, to deal with legacy clients. Taking a hint from this, rework xev_handle_unmaprequest to correctly detect these situations. A Withdrawn window may come back anywhere, even as a subwindow of something else, so the correct way to handle this state is to forget it ever existed. While i'm here, kill a dumb attempt to notice this in client_delete, and nuke the very unnecessary arguments. Todd confirmed this fixes the `race'. ok todd@, ok ok okan@
Diffstat (limited to 'calmwm.h')
-rw-r--r-- | calmwm.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/calmwm.h b/calmwm.h index 5234376..1343011 100644 --- a/calmwm.h +++ b/calmwm.h @@ -310,7 +310,7 @@ __dead void usage(void); struct client_ctx *client_find(Window); void client_setup(void); struct client_ctx *client_new(Window, struct screen_ctx *, int); -int client_delete(struct client_ctx *, int, int); +int client_delete(struct client_ctx *); void client_setactive(struct client_ctx *, int); void client_resize(struct client_ctx *); void client_lower(struct client_ctx *); |